Skip to content

add model builder skill#1745

Draft
mnabian wants to merge 8 commits into
NVIDIA:mainfrom
mnabian:model-builder-skill
Draft

add model builder skill#1745
mnabian wants to merge 8 commits into
NVIDIA:mainfrom
mnabian:model-builder-skill

Conversation

@mnabian

@mnabian mnabian commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@copy-pr-bot

copy-pr-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mnabian mnabian requested a review from melo-gonzo June 22, 2026 23:18
@CharlelieLrt

Copy link
Copy Markdown
Collaborator

@mnabian just curious: is it a 1-to-1 conversion of the older cursor rules into skills?
If so, does it keep all rules or does it updates on the rules? And is it worth deprecating the rules if they are replaced by these skills?

@melo-gonzo melo-gonzo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. You will not need to include skill-card.md or BENCHMARK.md - these will be generated by the nvskills-ci pipeline. Once you sync with the main branch we can invoke the CI pipeline and have a look at the reports generated and make any necessary changes.

To @CharlelieLrt's point - i think its ok to leave the rules as is, and simply point to them in the skills like you do here. For other skills, i've takne the approach of allowing the agent to self discover the rules by only pointing to the main folder/files. Adding specific references as you do here (e.g, pointing to MOD-00b may make the skill more token efficient, but also if we do end up changing the location of these rules in the future we'll have to go back an update all of the skills.

@mnabian

mnabian commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@mnabian

mnabian commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@mnabian

mnabian commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

@mnabian just curious: is it a 1-to-1 conversion of the older cursor rules into skills? If so, does it keep all rules or does it updates on the rules? And is it worth deprecating the rules if they are replaced by these skills?

I agree with Carmelo. I think the rules can stay there for now and point the skills to them (or have them discover the rules).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants