Repository navigation
Should some instance variables be local? #636
Description
There are in Decoder:
.memory,.processed_memory,.mask.
And,
- Each is set in
.initialize_decoder_states()(called from.forward()and.inference(), unconditionally). - Noone is re-assigned.
- Each is used in
.decode()only.
Should they be arguments of .decode()?
(If so, mask has to be added to .forward()/.inference(). memory is already there. processed_memory is produced from the latter.)
Activity
[-]Should some instance variable be local?[/-][+]Should some instance variableы be local?[/+][-]Should some instance variableы be local?[/-][+]Should some instance variables be local?[/+]