Skip to content

fix: derive macOS modifier state from keycode#196

Open
georgenijo wants to merge 1 commit into
Narsil:mainfrom
georgenijo:fix/macos-modifier-flags
Open

fix: derive macOS modifier state from keycode#196
georgenijo wants to merge 1 commit into
Narsil:mainfrom
georgenijo:fix/macos-modifier-flags

Conversation

@georgenijo

Copy link
Copy Markdown

Summary

  • classify FlagsChanged press/release from the physical keycode and device-specific flag
  • remove listener dependence on cached global flags, preventing stale-state drops
  • preserve separate left/right modifier handling, including Right Control
  • keep simulation-only flag state isolated from the listener

Test plan

  • cargo test --lib -- --test-threads=1
  • verified device masks against the active macOS SDK IOLLEvent.h

Needed by georgenijo/murmur-app#194 and its hotkey bug #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant