Skip to content

Fix #230 - Address v26.2.0 failures #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmarrec wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix #230 - Address v26.2.0 failures #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
026997a
#230 - Part 1 - missing ZoneControl:Humidistat, is because a setpoint…
jmarrec Aug 26, 2026
d3e7e55
to minimize diffs, we should use a dehum with 100.0 setpoint
jmarrec Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions model/simulationtests/air_chillers.osm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2120,7 +2120,8 @@ OS:ThermalZone,
, !- Illuminance Map Name
, !- Group Rendering Name
{ff54caa2-d05a-47a5-9bc1-5d642f69f023}, !- Thermostat Name
No; !- Use Ideal Air Loads
No, !- Use Ideal Air Loads
{178bb844-5197-4262-8020-8cac4bec82f4}; !- Humidistat Name

OS:Node,
{689d7840-72e3-413f-a322-832c38f6ba0b}, !- Handle
Expand Down Expand Up @@ -6323,7 +6324,8 @@ OS:Schedule:Constant,
OS:ZoneControl:Humidistat,
{1a4e23f0-663b-4219-a572-4294f9fbc89d}, !- Handle
Zone Control Humidistat 1, !- Name
{100f63ba-e9c6-4884-afd1-97ddc03ccee5}; !- Humidifying Relative Humidity Setpoint Schedule Name
{100f63ba-e9c6-4884-afd1-97ddc03ccee5}, !- Humidifying Relative Humidity Setpoint Schedule Name
{dbb28d83-a63a-4e40-ba3e-93ffc1c89a5e}; !- Dehumidifying Relative Humidity Setpoint Schedule Name

OS:ScheduleTypeLimits,
{9a5fe098-2d86-4ed4-b7bd-84d975147b01}, !- Handle
Expand All @@ -6333,6 +6335,30 @@ OS:ScheduleTypeLimits,
Continuous, !- Numeric Type
Percent; !- Unit Type

OS:Schedule:Constant,
{dbb28d83-a63a-4e40-ba3e-93ffc1c89a5e}, !- Handle
Dehumidifying Schedule 100 Percent, !- Name
{9a5fe098-2d86-4ed4-b7bd-84d975147b01}, !- Schedule Type Limits Name
100; !- Value

OS:ZoneControl:Humidistat,
{178bb844-5197-4262-8020-8cac4bec82f4}, !- Handle
Zone Control Humidistat 2, !- Name
{d9f06502-1fe8-4d83-ba84-8552abaa889a}, !- Humidifying Relative Humidity Setpoint Schedule Name
{cf84420d-2efd-4d5e-8ad6-288c8e6cf7f6}; !- Dehumidifying Relative Humidity Setpoint Schedule Name

OS:Schedule:Constant,
{d9f06502-1fe8-4d83-ba84-8552abaa889a}, !- Handle
Humidifying Schedule - OFF, !- Name
{9a5fe098-2d86-4ed4-b7bd-84d975147b01}, !- Schedule Type Limits Name
0; !- Value

OS:Schedule:Constant,
{cf84420d-2efd-4d5e-8ad6-288c8e6cf7f6}, !- Handle
Dehumidifying Schedule 100 Percent 2, !- Name
{9a5fe098-2d86-4ed4-b7bd-84d975147b01}, !- Schedule Type Limits Name
100; !- Value

OS:ZoneHVAC:Dehumidifier:DX,
{071d3bd9-9e5e-4abb-a215-48779317787c}, !- Handle
Zone HVAC Dehumidifier DX 1, !- Name
Expand Down
23 changes: 22 additions & 1 deletion model/simulationtests/airloop_and_zonehvac.osm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6123,7 +6123,28 @@ OS:Connection,
OS:ZoneControl:Humidistat,
{4ecf77f1-57a1-456b-90c4-5b4b5a9b4e6a}, !- Handle
Zone Control Humidistat 1, !- Name
; !- Humidifying Relative Humidity Setpoint Schedule Name
{353e3e4f-acd3-4752-a7bf-111811a68a08}, !- Humidifying Relative Humidity Setpoint Schedule Name
{7f508801-b056-4f71-9f37-307d2a235fa1}; !- Dehumidifying Relative Humidity Setpoint Schedule Name

OS:Schedule:Constant,
{353e3e4f-acd3-4752-a7bf-111811a68a08}, !- Handle
Humidifying Schedule 30 Percent, !- Name
{2557588f-b28a-4bb9-99aa-db4a77eaf86e}, !- Schedule Type Limits Name
30; !- Value

OS:ScheduleTypeLimits,
{2557588f-b28a-4bb9-99aa-db4a77eaf86e}, !- Handle
Percent, !- Name
0, !- Lower Limit Value
100, !- Upper Limit Value
Continuous, !- Numeric Type
Percent; !- Unit Type

OS:Schedule:Constant,
{7f508801-b056-4f71-9f37-307d2a235fa1}, !- Handle
Dehumidifying Schedule 100 Percent, !- Name
{2557588f-b28a-4bb9-99aa-db4a77eaf86e}, !- Schedule Type Limits Name
100; !- Value

OS:ZoneHVAC:Dehumidifier:DX,
{c99ee959-6537-44d2-b73f-65baa58af9df}, !- Handle
Expand Down
8 changes: 8 additions & 0 deletions model/simulationtests/airloop_and_zonehvac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@

# add ZoneHVACDehumidifierDX
humidistat = openstudio.model.ZoneControlHumidistat(model)
hum_schedule = openstudio.model.ScheduleConstant(model)
hum_schedule.setName("Humidifying Schedule - OFF")
hum_schedule.setValue(0.0)
humidistat.setHumidifyingRelativeHumiditySetpointSchedule(hum_schedule)
dehum_schedule = openstudio.model.ScheduleConstant(model)
dehum_schedule.setName("Dehumidifying Schedule 100 Percent")
dehum_schedule.setValue(100.0)
humidistat.setDehumidifyingRelativeHumiditySetpointSchedule(dehum_schedule)
zone.setZoneControlHumidistat(humidistat)
zone_hvac = openstudio.model.ZoneHVACDehumidifierDX(model)
zone_hvac.addToThermalZone(zone)
Expand Down
8 changes: 8 additions & 0 deletions model/simulationtests/airloop_and_zonehvac.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@

# add ZoneHVACDehumidifierDX
humidistat = OpenStudio::Model::ZoneControlHumidistat.new(model)
hum_schedule = OpenStudio::Model::ScheduleConstant.new(model)
hum_schedule.setName('Humidifying Schedule - OFF')
hum_schedule.setValue(0.0)
humidistat.setHumidifyingRelativeHumiditySetpointSchedule(hum_schedule)
dehum_schedule = OpenStudio::Model::ScheduleConstant.new(model)
dehum_schedule.setName('Dehumidifying Schedule 100 Percent')
dehum_schedule.setValue(100.0)
humidistat.setDehumidifyingRelativeHumiditySetpointSchedule(dehum_schedule)
zone.setZoneControlHumidistat(humidistat)
zone_hvac = OpenStudio::Model::ZoneHVACDehumidifierDX.new(model)
zone_hvac.addToThermalZone(zone)
Expand Down
30 changes: 28 additions & 2 deletions model/simulationtests/zone_hvac2.osm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2535,7 +2535,8 @@ OS:ThermalZone,
, !- Illuminance Map Name
, !- Group Rendering Name
{fa74fb19-b415-4b51-be06-a9204958f1da}, !- Thermostat Name
No; !- Use Ideal Air Loads
No, !- Use Ideal Air Loads
{dc8d61f8-cbc0-4488-8dfc-3892bc556944}; !- Humidistat Name

OS:Node,
{a83439d5-3834-4093-b74b-cb01493490bd}, !- Handle
Expand Down Expand Up @@ -6323,7 +6324,8 @@ OS:Schedule:Constant,
OS:ZoneControl:Humidistat,
{a424e69b-eafb-47e4-a7bb-d68b2233dd71}, !- Handle
Zone Control Humidistat 1, !- Name
{0c05910e-8d10-4034-bbef-eac1f8a3f40f}; !- Humidifying Relative Humidity Setpoint Schedule Name
{0c05910e-8d10-4034-bbef-eac1f8a3f40f}, !- Humidifying Relative Humidity Setpoint Schedule Name
{bd2c9eab-ad08-4e3e-be65-9b15091e8eb8}; !- Dehumidifying Relative Humidity Setpoint Schedule Name

OS:ScheduleTypeLimits,
{121415a7-cad3-42de-abea-9f2d8bda9d1c}, !- Handle
Expand All @@ -6333,6 +6335,30 @@ OS:ScheduleTypeLimits,
Continuous, !- Numeric Type
Percent; !- Unit Type

OS:Schedule:Constant,
{bd2c9eab-ad08-4e3e-be65-9b15091e8eb8}, !- Handle
Dehumidifying Schedule 100 Percent, !- Name
{121415a7-cad3-42de-abea-9f2d8bda9d1c}, !- Schedule Type Limits Name
100; !- Value

OS:ZoneControl:Humidistat,
{dc8d61f8-cbc0-4488-8dfc-3892bc556944}, !- Handle
Zone Control Humidistat 2, !- Name
{7bc27533-3a3b-4cae-90ab-3c29bc5366a3}, !- Humidifying Relative Humidity Setpoint Schedule Name
{c8ebb8e2-bc38-4504-bfab-939153134472}; !- Dehumidifying Relative Humidity Setpoint Schedule Name

OS:Schedule:Constant,
{7bc27533-3a3b-4cae-90ab-3c29bc5366a3}, !- Handle
Humidifying Schedule - OFF, !- Name
{121415a7-cad3-42de-abea-9f2d8bda9d1c}, !- Schedule Type Limits Name
0; !- Value

OS:Schedule:Constant,
{c8ebb8e2-bc38-4504-bfab-939153134472}, !- Handle
Dehumidifying Schedule 100 Percent 2, !- Name
{121415a7-cad3-42de-abea-9f2d8bda9d1c}, !- Schedule Type Limits Name
100; !- Value

OS:ZoneHVAC:Dehumidifier:DX,
{9d96e4ee-470b-4621-b602-62641af54f03}, !- Handle
Zone HVAC Dehumidifier DX 1, !- Name
Expand Down
10 changes: 10 additions & 0 deletions model/simulationtests/zone_hvac2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,16 @@
story_3_east_thermal_zone.setZoneControlHumidistat(humidistat)

# Add ZoneHVACDehumidifierDX
dx_hum_schedule = openstudio.model.ScheduleConstant(model)
dx_hum_schedule.setName("Humidifying Schedule - OFF")
dx_hum_schedule.setValue(0.0)
dx_dehum_schedule = openstudio.model.ScheduleConstant(model)
dx_dehum_schedule.setName("Dehumidifying Schedule 100 Percent")
dx_dehum_schedule.setValue(100.0)
dx_humidistat = openstudio.model.ZoneControlHumidistat(model)
dx_humidistat.setHumidifyingRelativeHumiditySetpointSchedule(dx_hum_schedule)
dx_humidistat.setDehumidifyingRelativeHumiditySetpointSchedule(dx_dehum_schedule)
story_1_west_thermal_zone.setZoneControlHumidistat(dx_humidistat)
zoneHVACDehumidifierDX = openstudio.model.ZoneHVACDehumidifierDX(model)
zoneHVACDehumidifierDX.addToThermalZone(story_1_west_thermal_zone)

Expand Down
10 changes: 10 additions & 0 deletions model/simulationtests/zone_hvac2.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,16 @@
story_3_east_thermal_zone.setZoneControlHumidistat(humidistat)

# Add ZoneHVACDehumidifierDX
dx_hum_schedule = OpenStudio::Model::ScheduleConstant.new(model)
dx_hum_schedule.setName('Humidifying Schedule - OFF')
dx_hum_schedule.setValue(0.0)
dx_dehum_schedule = OpenStudio::Model::ScheduleConstant.new(model)
dx_dehum_schedule.setName('Dehumidifying Schedule 100 Percent')
dx_dehum_schedule.setValue(100.0)
dx_humidistat = OpenStudio::Model::ZoneControlHumidistat.new(model)
dx_humidistat.setHumidifyingRelativeHumiditySetpointSchedule(dx_hum_schedule)
dx_humidistat.setDehumidifyingRelativeHumiditySetpointSchedule(dx_dehum_schedule)
story_1_west_thermal_zone.setZoneControlHumidistat(dx_humidistat)
zoneHVACDehumidifierDX = OpenStudio::Model::ZoneHVACDehumidifierDX.new(model)
zoneHVACDehumidifierDX.addToThermalZone(story_1_west_thermal_zone)

Expand Down
Loading