Refactor natron build deps packages to work with Qt5 & Qt6#1042
Conversation
d44e68f to
1f06583
Compare
YakoYakoYokuYoku
left a comment
There was a problem hiding this comment.
Same as #1044. I cannot approve this based on what it was said there.
This is completely unnecessary and just stonewalling. Please stop. Refactoring this is necessary so that the windows packages can be used by both branches. In this particular case it is a cross-cutting concern for both branches since the Qt5 code would need to use the Qt5 package and the Qt6 code would use the Qt6 one. Both of them depend on a common package. Not doing this means I'll have to manage different sets of packages for each branch. That is unnecessary work and will make maintaining CI for both branches more annoying. |
- Create natron-build-deps-common package to hold all common deps. - Modified natron-build-deps-qt5 to use new natron-build-deps-common package. - Added natron-build-deps-qt6 package for Qt6 builds.
1f06583 to
bebdba7
Compare
Have approval from rodlie and devernay.
|
Thanks for the review. |
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Have you tested your changes (if applicable)? If so, how?
Yes. Build pacman repo action builds packages successfully and the Windows installer build action also builds Qt5 installers with these refactored packages successfully.