Respect tag hiding behavior when selecting a favorite tag

[feilen]

Rather simple - so much so that I'm wondering whether this is intended behavior I'm misunderstanding.

Currently, when disabling "Show tags" from the User Experience menu, it correctly hides tags in search results... but not for favorite tags. This comes up a lot for me as 3 out of 6 of my quick launch are all favorite tags.

With this change we hide tags in all contexts (including with favorites) if Show Tags is disabled.

If showing tags when a favorite is selected is actually the intended behavior, I can instead break this out into a separate config option - but that seems less clean overall.

[marunjar]

You are right - changed behaviour was always intentional.

Once there was a related comment which got lost with 8c1156e:
Hide tags view if tags are empty or if user has selected to hide them when query doesn't match

As soon as a result has tag matching query, tags will be visible.
Unless they are always shown because of settings.

When you then have some favorite tag and you select it, it should behave same as when you're searching manually for that tag.
Tags will be shown for results then, because query in the background is matching.