HID: asus: fix ROG Ally joystick ring LEDs, add strobe/direction - #3
Open
kndclark wants to merge 4 commits into
Open
HID: asus: fix ROG Ally joystick ring LEDs, add strobe/direction#3kndclark wants to merge 4 commits into
kndclark wants to merge 4 commits into
Conversation
NeroReflex
force-pushed
the
ally
branch
4 times, most recently
from
July 26, 2026 01:49
f759008 to
bbd3c71
Compare
NeroReflex
force-pushed
the
ally
branch
2 times, most recently
from
July 26, 2026 16:51
7c00659 to
9bc9553
Compare
kndclark
force-pushed
the
ally-led-fixes
branch
3 times, most recently
from
July 26, 2026 21:43
a59abf3 to
308d8df
Compare
kndclark
changed the title
kndclark
force-pushed
the
ally-led-fixes
branch
2 times, most recently
from
July 31, 2026 21:44
fc0d3c6 to
79119b0
Compare
NeroReflex
force-pushed
the
ally
branch
3 times, most recently
from
August 13, 2026 14:39
5eb0768 to
ecdba22
Compare
ASUS ROG laptops supports a protocol called Aura to control LEDs over multiple zones: this protocol allows changing effects, colors, brightness and transitioning speed across different colors on certain effects. Add support for said protocol to allow complete customization of LEDs mounted on the ROG ally and laid out the foundation for all other laptops. Assisted-by: glm-5.2 Assisted-by: claude-fable-5 Signed-off-by: Denis Benato <denis.benato@linux.dev> Signed-off-by: Khamunetri Clark <khamunetriclark@gmail.com>
The Ally X gamepad interface delivers 16-byte input reports (report ID, six 16-bit axes, and three button bytes). Pin the report struct size to the report size definition with a static_assert to prevent drift against the wire format. Signed-off-by: Khamunetri Clark <khamunetriclark@gmail.com>
Multicolor LEDs on ROG Ally expose 3 color components for RGB lighting, while other devices expose 6 components for primary and background colors. Describe exposed color components per device descriptor, report 3 for the Ally, and dynamically set num_colors and color set attributes. Tested on a ROG Ally X. Signed-off-by: Khamunetri Clark <khamunetriclark@gmail.com>
Align the static lighting effect string to "monocolor" with standard sysfs aliases, identify RGB devices using LED_COLOR_ID_RGB, and default joystick rings to dark (0x00) until configured by userspace. Tested on a ROG Ally X. Signed-off-by: Khamunetri Clark <khamunetriclark@gmail.com>
kndclark
force-pushed
the
ally-led-fixes
branch
from
August 14, 2026 17:55
79119b0 to
ad72f1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First patch fixes the joystick ring on top of the multi-zone rework. hardware tested on an Ally X across all modes and suspend/resume. The remaining three restore effects that the rework didn't carry over: strobe, a background color for breathing, and direction for animated effects.