Fix broken links, typos, and minor code quality issues#2118
Open
apoorvdarshan wants to merge 1 commit into
Open
Fix broken links, typos, and minor code quality issues#2118apoorvdarshan wants to merge 1 commit into
apoorvdarshan wants to merge 1 commit into
Conversation
- Fix all Javadoc links: netflix.github.com → netflix.github.io (GitHub Pages domain migration) - Replace stale Travis CI badge with GitHub Actions CI badge - Fix variable name typo: springframeworkVesion → springframeworkVersion in hystrix-javanica/build.gradle - Fix test class name typo: HystricsMetricsControllerTest → HystrixMetricsControllerTest - Replace StringBuffer with StringBuilder in HystrixCommandCompletion.toString()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
netflix.github.com→netflix.github.ioacross READMEs, build.gradle, and Clojure source (GitHub Pages domain migration)springframeworkVesion→springframeworkVersioninhystrix-javanica/build.gradleHystricsMetricsControllerTest→HystrixMetricsControllerTestStringBufferwithStringBuilderinHystrixCommandCompletion.toString()(thread safety not needed, standard Java best practice)Files changed (12)
README.md,hystrix-core/README.md,hystrix-core/build.gradle,hystrix-contrib/README.md,hystrix-contrib/hystrix-codahale-metrics-publisher/README.md,hystrix-contrib/hystrix-servo-metrics-publisher/README.md,hystrix-contrib/hystrix-yammer-metrics-publisher/README.md,hystrix-contrib/hystrix-request-servlet/README.md,hystrix-contrib/hystrix-clj/src/main/clojure/com/netflix/hystrix/core.cljREADME.mdhystrix-contrib/hystrix-javanica/build.gradlehystrix-contrib/hystrix-metrics-event-stream-jaxrs/.../HystrixMetricsControllerTest.javahystrix-core/.../HystrixCommandCompletion.javaTest plan