fix(applications): show the logo shipped with the app - #1281
Merged
Conversation
The table kept a logo only when it was an absolute URL, which is what a repository serves. An app installed outside any repository publishes its logo with its own UI bundle, and list-modules reports that local path, so those rows fell back to the generic logo while the app drawer, fed by the same data, showed the right one. Keep the whole chain instead: the repository logo first, then the one the app published with its own bundle. A published bundle can disappear, so walk to the next candidate on a load error and end on the shipped asset.
andre8244
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Applications table kept a logo only when it was an absolute URL, which is what a repository serves. An app installed outside any repository publishes its logo with its own UI bundle, and
list-modulesreports that local path, so those rows fell back to the generic logo while the app drawer, fed by the same data, showed the right one.I keep the whole chain instead: the repository logo first, then the one the app published with its own bundle. A published bundle can disappear, so I walk to the next candidate on a load error and end on the shipped default asset.
Split out of #1247, where the same change is reverted.
NethServer/dev#8139