Skip to content

Apply cross-validation settings - #1130

Open
stanbot8 wants to merge 1 commit into
NeuroTechX:developfrom
stanbot8:apply-cross-validation-settings
Open

Apply cross-validation settings#1130
stanbot8 wants to merge 1 commit into
NeuroTechX:developfrom
stanbot8:apply-cross-validation-settings

Conversation

@stanbot8

@stanbot8 stanbot8 commented Aug 2, 2026

Copy link
Copy Markdown

Apply evaluation defaults and caller cross-validation settings.

Closes #1110.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f8b23e3db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread moabb/evaluations/evaluations.py
Comment thread moabb/evaluations/base.py Outdated
@stanbot8
stanbot8 marked this pull request as draft August 2, 2026 18:48
@stanbot8
stanbot8 force-pushed the apply-cross-validation-settings branch from 5f8b23e to 6b4d6e3 Compare August 11, 2026 00:22
@stanbot8 stanbot8 changed the title Apply cross-validation settings consistently Apply cross-validation settings Aug 11, 2026
@stanbot8
stanbot8 force-pushed the apply-cross-validation-settings branch from 0266412 to 6b4d6e3 Compare August 11, 2026 01:04
@stanbot8
stanbot8 force-pushed the apply-cross-validation-settings branch 2 times, most recently from 564f773 to 73f0838 Compare August 11, 2026 20:09
@stanbot8

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 73f08385dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@stanbot8
stanbot8 marked this pull request as ready for review August 11, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent n_splits / cv_kwargs handling in BaseEvaluation._resolve_cv and Within* evaluations

1 participant