Skip to content

Update All-Inkl (kas) DNS plugin to certbot-dns-kas ~=1.0#5637

Open
mobilandi wants to merge 5 commits into
NginxProxyManager:developfrom
mobilandi:develop
Open

Update All-Inkl (kas) DNS plugin to certbot-dns-kas ~=1.0#5637
mobilandi wants to merge 5 commits into
NginxProxyManager:developfrom
mobilandi:develop

Conversation

@mobilandi

@mobilandi mobilandi commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

What

Bumps the bundled All-Inkl (kas) DNS plugin from certbot-dns-kas ~=0.1.1
to ~=1.0 and drops the now-unnecessary kasserver dependency.

Why

certbot-dns-kas 1.0.0 is a ground-up rewrite that talks to the All-Inkl KAS
API directly (only requests; no more kasserver/zeep/lxml). The pinned
~=0.1.1 is what NPM users currently get, and it has several bugs that 1.0.0
fixes:

  • Wildcard + apex certificates (example.com + *.example.com) now work —
    0.1.x overwrote the shared _acme-challenge TXT record, so validation failed.
  • Multi-label public suffixes (.or.at, .co.uk, .com.au, …) now resolve
    the correct zone — 0.1.x assumed the last two labels and failed with
    zone_not_found.
  • Cleanup removes exactly the challenge record it created (no orphaned
    _acme-challenge TXT records left behind).

Because the rewrite no longer uses kasserver, the dependencies field is
cleared (this also drops the heavy zeep/lxml chain).

Closes #1106, closes #2178

This also addresses the root cause behind #5349 (already closed): the bundled
0.1.x plugin failed on wildcard+apex certificates and on multi-label TLDs such
as .or.at. certbot-dns-kas 1.0.0 fixes both.

Notes

  • Requires certbot >= 2.0 and Python >= 3.9, both satisfied by current NPM
    images.
  • Verified end-to-end in NPM against the live KAS API: wildcard+apex issuance
    and clean teardown.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • API changes
  • Performance improvement
  • Test addition or update

AI Usage

  • AI was used to write this
  • AI was used to review this

@nginxproxymanagerci

Copy link
Copy Markdown

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
certbot-node: Pulling from nginxproxymanager/nginx-full
eef7591652d2: Pulling fs layer
72c03230f136: Pulling fs layer
b731921610be: Pulling fs layer
e2d29f7dca20: Pulling fs layer
a9e37da47314: Pulling fs layer
76a40e6224ae: Pulling fs layer
7721130e1549: Pulling fs layer
2e6541e45aa6: Pulling fs layer
6b77647c6ed3: Pulling fs layer
38e1aade8eb9: Pulling fs layer
4e870768a58b: Pulling fs layer
00a007ac00b5: Pulling fs layer
197bb771f6c6: Pulling fs layer
37f35644121a: Pulling fs layer
62a32046b3b4: Pulling fs layer
c9c591fb2631: Pulling fs layer
e59bac12cc78: Pulling fs layer
d21a9e2c3de7: Pulling fs layer
883aa7949c07: Pulling fs layer
8315aed5a19f: Pulling fs layer
00a007ac00b5: Download complete
8315aed5a19f: Download complete
b731921610be: Download complete
38e1aade8eb9: Download complete
d21a9e2c3de7: Download complete
1979032ab388: Download complete
eef7591652d2: Download complete
a9e37da47314: Download complete
37f35644121a: Download complete
e59bac12cc78: Download complete
2e6541e45aa6: Download complete
7721130e1549: Download complete
76a40e6224ae: Download complete
883aa7949c07: Download complete
197bb771f6c6: Download complete
4e870768a58b: Download complete
e2d29f7dca20: Download complete
c9c591fb2631: Download complete
72c03230f136: Download complete
b731921610be: Pull complete
72c03230f136: Pull complete
a9e37da47314: Pull complete
76a40e6224ae: Pull complete
e2d29f7dca20: Pull complete
2e6541e45aa6: Pull complete
7721130e1549: Pull complete
6b77647c6ed3: Download complete
38e1aade8eb9: Pull complete
6b77647c6ed3: Pull complete
00a007ac00b5: Pull complete
4e870768a58b: Pull complete
e59bac12cc78: Pull complete
197bb771f6c6: Pull complete
62a32046b3b4: Download complete
c9c591fb2631: Pull complete
37f35644121a: Pull complete
883aa7949c07: Pull complete
8315aed5a19f: Pull complete
d21a9e2c3de7: Pull complete
eef7591652d2: Pull complete
62a32046b3b4: Pull complete
Digest: sha256:339b8df1e0fd70f0d283a93328ae8ddc080d870230d0526b279f872fd62b7fd5
Status: Downloaded newer image for nginxproxymanager/nginx-full:certbot-node
docker.io/nginxproxymanager/nginx-full:certbot-node
�[1;34m❯ �[1;36mBuilding Frontend ...�[0m
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @uiw/react-textarea-code-editor@3.1.1" has unmet peer dependency "@babel/runtime@>=7.10.0".
[4/4] Building fresh packages...
Done in 44.85s.
yarn run v1.22.22
$ biome lint
Checked 226 files in 89ms. No fixes applied.
Done in 0.16s.
yarn run v1.22.22
$ formatjs compile-folder src/locale/src src/locale/lang
Done in 0.34s.
yarn run v1.22.22
$ /app/frontend/node_modules/.bin/vitest run --no-color

 RUN  v4.1.8 /app/frontend

 ❯ src/locale/Utils.test.tsx (0 test)

⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/locale/Utils.test.tsx [ src/locale/Utils.test.tsx ]
Error: EOF while parsing a value at line 1 column 0
  Plugin: builtin:vite-json
  File: [object Object]
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯


 Test Files  1 failed (1)
      Tests  no tests
   Start at  17:45:00
   Duration  495ms (transform 118ms, setup 71ms, import 0ms, tests 0ms, environment 195ms)

$ formatjs compile-folder src/locale/src src/locale/lang

$ ./src/locale/scripts/locale-sort.sh
bg.json is already sorted
cs.json is already sorted
de.json is already sorted
en.json is already sorted
es.json is already sorted
et.json is already sorted
fr.json is already sorted
ga.json is already sorted
hu.json is already sorted
id.json is already sorted
it.json is already sorted
ja.json is already sorted
ko.json is already sorted
nl.json is already sorted
no.json is already sorted
pl.json is already sorted
pt.json is already sorted
ru.json is already sorted
sk.json is already sorted
tr.json is already sorted
vi.json is already sorted
zh.json is already sorted

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ALL-Inkl DNS Challange Add All-inkl / kasserver as DNS-01 Provider

1 participant