Skip to content

🐛 [fix] Scope Squirrel artifact gate to Windows - #212

Merged
Nick2bad4u merged 2 commits into
mainfrom
fix/scope-squirrel-windows-gate
Sep 3, 2026
Merged

Nick2bad4u merged 2 commits into
mainfrom
fix/scope-squirrel-windows-gate

Conversation

@Nick2bad4u

Copy link
Copy Markdown
Owner

Summary

  • scope the packaged-artifact guard to Squirrel.Windows outputs
  • preserve Electron's legitimate macOS Squirrel.framework
  • cover Windows helper, package, directory, and renamed-installer leakage in the regression test

Why

The first unpublished v30.0.2 release run correctly removed Squirrel.Windows from the Windows builds, but the new cross-platform artifact guard also matched Electron's bundled macOS updater framework. This keeps the Windows protection while allowing the supported macOS runtime component.

Verification

  • node --max-old-space-size=8192 ./node_modules/vitest/vitest.mjs --config vitest.config.ts --run tests/unit/packaging/runPackagedSmoke.test.ts tests/unit/packaging/electronBuilderConfig.test.ts --maxWorkers 1
  • npx prettier --check scripts/run-packaged-smoke.mjs tests/unit/packaging/runPackagedSmoke.test.ts
  • npx eslint scripts/run-packaged-smoke.mjs tests/unit/packaging/runPackagedSmoke.test.ts
  • git diff --check

Release recovery

No GitHub release was published. After this merges and required checks pass, the unpublished v30.0.2 tag will be moved from the failed version-bump commit to the repaired main commit, then the release workflow's explicit reuse-current-version path will be used.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-03T04:38:21.068015Z 4d0abdc New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greetings, thanks for opening a pull request, I'll look when I can.

@codacy-production

codacy-production Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 9 complexity · 0 duplication

Metric Results
Complexity 9
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.09%. Comparing base (097a80d) to head (4d0abdc).
⚠️ Report is 1 commits behind head on main.

Flag Coverage Δ
electron-app 63.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   63.09%   63.09%           
=======================================
  Files           8        8           
  Lines        1084     1084           
  Branches      208      208           
=======================================
  Hits          684      684           
  Misses        299      299           
  Partials      101      101           

Impacted file tree graph

Components Coverage Δ
⚡ Core Electron Process ∅ <ø> (∅)
Renderer & UI ∅ <ø> (∅)
Utilities 63.70% <ø> (ø)
FIT Parsing ∅ <ø> (∅)
Window State Management ∅ <ø> (∅)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5940413...4d0abdc. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

@Nick2bad4u
Nick2bad4u merged commit e09a1f8 into main Sep 3, 2026
34 checks passed
@Nick2bad4u
Nick2bad4u deleted the fix/scope-squirrel-windows-gate branch September 3, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant