You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
🐛 [fix] Scope Squirrel artifact gate to Windows - #212
cover Windows helper, package, directory, and renamed-installer leakage in the regression test
Why
The first unpublished v30.0.2 release run correctly removed Squirrel.Windows from the Windows builds, but the new cross-platform artifact guard also matched Electron's bundled macOS updater framework. This keeps the Windows protection while allowing the supported macOS runtime component.
No GitHub release was published. After this merges and required checks pass, the unpublished v30.0.2 tag will be moved from the failed version-bump commit to the repaired main commit, then the release workflow's explicit reuse-current-version path will be used.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.09%. Comparing base (097a80d) to head (4d0abdc). ⚠️ Report is 1 commits behind head on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Squirrel.frameworkWhy
The first unpublished v30.0.2 release run correctly removed Squirrel.Windows from the Windows builds, but the new cross-platform artifact guard also matched Electron's bundled macOS updater framework. This keeps the Windows protection while allowing the supported macOS runtime component.
Verification
node --max-old-space-size=8192 ./node_modules/vitest/vitest.mjs --config vitest.config.ts --run tests/unit/packaging/runPackagedSmoke.test.ts tests/unit/packaging/electronBuilderConfig.test.ts --maxWorkers 1npx prettier --check scripts/run-packaged-smoke.mjs tests/unit/packaging/runPackagedSmoke.test.tsnpx eslint scripts/run-packaged-smoke.mjs tests/unit/packaging/runPackagedSmoke.test.tsgit diff --checkRelease recovery
No GitHub release was published. After this merges and required checks pass, the unpublished
v30.0.2tag will be moved from the failed version-bump commit to the repairedmaincommit, then the release workflow's explicitreuse-current-versionpath will be used.