-
-
Notifications
You must be signed in to change notification settings - Fork 20k
linux: Adjust config to allow booting of installer ISO on ppc64 #486572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alyssais
merged 2 commits into
NixOS:master
from
OPNA2608:fix/ppc64-linux-kernel-hfsiso-startup
Jun 10, 2026
+10
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does 64-bit POWER also need this?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have 64-bit POWER hardware, and
isPoweris included under that.Did you mean specifically the built-in HFS support, since the line right below it also builds-in HFS+ support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me expand on that I guess…
For booting, there needs to be a HFS+ (or apparently HFS) partition with some special magic applied to it. #488831 would end up using HFS+ for our ISOs, but I don't yet know what would happen if you were to install a system to disk and boot from that. I imagine these settings would still be necessary there though.
Now AFAIU, booting from HFS should work the same way, and would presumably run into the same requirement. I'm not sure if
xorrisocan produce such an installer, and I have no real reason to mess with that since my G5 supports HFS+. My machine is also busy with a world rebuild right now, so doing any testing there is gonna take some days…When it comes to booting an installed system though, the user will be taking care of the partition format, and they could maybe select HFS there. I got a spare disk for my machine recently, so I could give that a try some time… I think actually installing NixOS will need further module changes first though, and I would prolly work on those with HFS+ as the intended boot partition format before trying with HFS.
Can drop
HFS_FSfor now and re-add it later if desired - doesn't look like it's a requirement forHFSPLUS_FS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped
HFS_FSfor now, assuming that's what the comment was about.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I just meant I thought maybe this should be a
Power32check, because I thought Apple only used 32-bit. Evidently I was wrong!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well… I'll prolly still leave
HFS_FSdropped for now, until I can actually try that out much later and see how it behaves ^^".The last series of POWER systems that they released, the G5 series (2003 - 2006), had 64-bit IBM PPC970 CPU(s) in them: PowerMac G5 desktop, iMac G5 AIO, Xserve G5 rack server.