euro-office-documentserver: init at 9.3.1 by onny · Pull Request #504934 · NixOS/nixpkgs

onny · 2026-03-30T09:04:35Z

packaging euro-office-documentserver, a hard-fork of onlyoffice-documentserver and „an online office suite comprising viewers and editors“

run tests with:

nix build -L .#euro-office-documentserver.passthru.tests.onlyoffice

Things done

onny · 2026-03-31T08:40:40Z

thank you @SuperSandro2000

dotlambda · 2026-04-03T05:02:32Z

          # needs to be ran wrapped in FHS for now
          # because the default config refers to many FHS paths
-          ExecStart = "${cfg.package.fhs}/bin/onlyoffice-wrapper ${cfg.package.fileconverter}/bin/fileconverter";
+          ExecStart = "${lib.getExe cfg.package.fhs} ${cfg.package.fileconverter}/bin/fileconverter";


Suggested change

ExecStart = "${lib.getExe cfg.package.fhs} ${cfg.package.fileconverter}/bin/fileconverter";

ExecStart = "${lib.getExe cfg.package.fhs} ${lib.getExe cfg.package.fileconverter}";

dotlambda · 2026-04-03T05:02:45Z

          };
          serviceConfig = {
-            ExecStart = "${cfg.package.fhs}/bin/onlyoffice-wrapper ${cfg.package.docservice}/bin/docservice";
+            ExecStart = "${lib.getExe cfg.package.fhs} ${cfg.package.docservice}/bin/docservice";


Suggested change

ExecStart = "${lib.getExe cfg.package.fhs} ${cfg.package.docservice}/bin/docservice";

ExecStart = "${lib.getExe cfg.package.fhs} ${lib.getExe cfg.package.docservice}";

dotlambda · 2026-04-03T05:04:19Z

+      --use-system=true
+
+    mkdir -p $out/bin
+    cp ${x2t}/bin/x2t $out/bin


Suggested change

cp ${x2t}/bin/x2t $out/bin

ln -s ${lib.getExe x2t} $out/bin

(see other comment - this would make sense but I've had to convert several ln -s to cp because the codebase uses calls that don't follow symlinks, so not obvious if this is possible here)

dotlambda · 2026-04-03T05:04:45Z

+
+    mkdir -p $out/bin
+    cp ${x2t}/bin/x2t $out/bin
+    cat >$out/bin/DoctRenderer.config <<EOF


Why is a config file in $out/bin?

Because x2t hard-codes looking for it there. Earlier I carried a patch in the onlyoffice-documentserver package to load it from ../etc instead, but that was a pain to maintain so I gave in and dropped that.

Euro-office promises to be more open to contributions, so maybe we can fix it upstream this time - but not sure if it should be a priority.

dotlambda · 2026-04-03T05:05:01Z

+    echo Generating presentation themes
+    # creates temporary files next to sources...
+    mkdir working
+    cp ${x2t.components.sdkjs}/slide/themes/src/* working


Suggested change

cp ${x2t.components.sdkjs}/slide/themes/src/* working

ln -s ${x2t.components.sdkjs}/slide/themes/src/* working

this is worth testing, but generally a lot of the codebase is using calls that don't follow symlinks, so I had to convert a bunch of things that I initially used symlinks for to use cp.

dotlambda · 2026-04-03T05:05:38Z

+      # equivalent of usr/bin/documentserver-flush-cache.sh,
+      # busts cache also when fonts collection changes
+      mkdir $out/var/www/onlyoffice/documentserver/web-apps
+      ${lndir}/bin/lndir -silent ${x2t.components.web-apps} $out/var/www/onlyoffice/documentserver/web-apps


Suggested change

${lndir}/bin/lndir -silent ${x2t.components.web-apps} $out/var/www/onlyoffice/documentserver/web-apps

${lib.getExe lndir} -silent ${x2t.components.web-apps} $out/var/www/onlyoffice/documentserver/web-apps

is this really a pattern we want to push even in 'simple' cases like this? do we have that written down in a style guide somewhere yet?

is this really a pattern we want to push even in 'simple' cases like this?

Yes, it is IMHO. If someone creates an overlay that overrides lndir such that the main program is no longer called lndir, we still want it to work correctly as long as the mainProgram is set correctly.

With lib.getExe we get a single source of truth for the relevant executable in a package. Yes, we want that.

Doesn't that conflict with the advice to move from runCommand to mkDerivation and put the dependencies in nativeBuildInputs? Since people do that we can't expect overlays that change the main program to work anyway, right?

https://nixos.org/manual/nixpkgs/unstable/ also still uses the {pkg}/bin/pkg pattern in a bunch of places and doesn't document a clear preference.

Doesn't that conflict with the advice to move from runCommand to mkDerivation and put the dependencies in nativeBuildInputs? Since people do that we can't expect overlays that change the main program to work anyway, right?

That's a fair point I hadn't thought about. I'll have to think on that.

https://nixos.org/manual/nixpkgs/unstable/ also still uses the {pkg}/bin/pkg pattern in a bunch of places and doesn't document a clear preference.

Instances of that pattern should 100% be replaced with lib.getExe or lib.getExe'.

It seems that a .exe attribute would pay off in terms of UX, without performance cost:

measure treewide .exe attribute #510543

The increase in allocation is offset by better collectability. Eval times appear shorter.

I think it'd be nice. Wdyt?

dotlambda · 2026-04-03T05:06:44Z

+        ];
+
+        extraBuildCommands = ''
+          mkdir -p $out/var/{lib/onlyoffice,www}


lib/onlyoffice seems unused

raboof · 2026-04-03T07:40:23Z

For background: euro-office is a fork of onlyoffice, so a lot of the comments here are actually comments on the onlyoffice package (too). As onlyoffice-documentserver maintainer, I'm already in contact with onny to see if/how we can co-maintain to keep things reasonably in sync, stay tuned.

Pandapip1

Mostly nitpicks

Pandapip1 · 2026-04-11T22:03:02Z

+    mkdir -p $out/web
+    mkdir -p $out/converter
+    mkdir -p $out/images
+    mkdir -p $out/fonts


Nitpick: this can be simplified

Suggested change

mkdir -p $out/web

mkdir -p $out/converter

mkdir -p $out/images

mkdir -p $out/fonts

mkdir -p $out/{web,converter,images,fonts}

Also, stdenvNoCC.mkDerivation instead of runCommand is my strong preference since:

It has better compatibility with other tooling

It lets you run allfontsgen in the build phase and copy to $out in the install phase

It lets you add script dependencies such as x2t, allfontsgen, etc... to nativeBuildInputs

Pandapip1 · 2026-04-11T22:08:03Z

+
+    echo Generating fonts
+    export CUSTOM_FONTS_PATHS=${lib.concatStringsSep ":" extra-fonts}
+    ${x2t.components.allfontsgen}/bin/allfontsgen \


Nit: either do the mkDerivation approach or

Suggested change

${x2t.components.allfontsgen}/bin/allfontsgen \

${lib.getExe x2t.components.allfontsgen} \

Pandapip1 · 2026-04-11T22:09:43Z

+    ${lib.getExe x2t.components.allthemesgen} \
+      --converter-dir="$out/bin"\
+      --src="working"\
+      --output="$out/images"
+    ${x2t.components.allthemesgen}/bin/allthemesgen \
+      --converter-dir="$out/bin"\
+      --src="working"\
+      --output="$out/images"\
+      --postfix="ios"\
+      --params="280,224"
+    ${x2t.components.allthemesgen}/bin/allthemesgen \


Suggested change

${lib.getExe x2t.components.allthemesgen} \

--converter-dir="$out/bin"\

--src="working"\

--output="$out/images"

${x2t.components.allthemesgen}/bin/allthemesgen \

--converter-dir="$out/bin"\

--src="working"\

--output="$out/images"\

--postfix="ios"\

--params="280,224"

${x2t.components.allthemesgen}/bin/allthemesgen \

${lib.getExe x2t.components.allthemesgen} \

--converter-dir="$out/bin"\

--src="working"\

--output="$out/images"

${lib.getExe x2t.components.allthemesgen} \

--converter-dir="$out/bin"\

--src="working"\

--output="$out/images"\

--postfix="ios"\

--params="280,224"

${lib.getExe x2t.components.allthemesgen} \

Pandapip1 · 2026-04-11T22:14:25Z

+      echo "[]" > $out/var/www/onlyoffice/documentserver/sdkjs-plugins/plugin-list-default.json
+
+      mkdir -p $out/var/www/onlyoffice/documentserver/server/schema
+      cp -r ${server-src}/schema/* $out/var/www/onlyoffice/documentserver/server/schema


Nitpick: would you mind opening (and linking to in comments) upstream issues for not following symlinks? I'd do it myself except I'm not familiar with the codebase and don't have the time to test every instance of not following symlinks myself.

Pandapip1 · 2026-04-11T22:16:01Z

+
+      ## required for bwrap --bind
+      chmod u+w $out/var
+      mkdir -p $out/var/lib/onlyoffice


It looks like this isn't used in the main derivation? Why is this here?

Pandapip1 · 2026-04-11T22:20:26Z

+  common = buildNpmPackage (finalAttrs: {
+    name = "euro-office-server-Common";
+    src = server-src;
+    sourceRoot = "${finalAttrs.src.name}/Common";
+    npmDepsHash = "sha256-zFGqDtnNFzXCwp6uvK04GDMRG6BATv6ti3Wi8ikLjBU=";
+    dontNpmBuild = true;
+    postPatch = ''
+      # https://github.com/ONLYOFFICE/build_tools/blob/ef8153c053bed41909ceb0762b124f8fe7faa0a7/scripts/build_server.py#L34
+      sed -e "s/^const buildVersion = '[0-9.]*'/const buildVersion = '${version}'/" -i sources/commondefines.js
+    '';
+    postInstall = ''
+      ln -s $out/lib/node_modules/common $out/lib/node_modules/Common
+    '';
+  });
+  docservice = buildNpmPackage (finalAttrs: {
+    name = "euro-office-server-DocService";
+    src = server-src;
+    sourceRoot = "${finalAttrs.src.name}/DocService";
+    nativeBuildInputs = [
+      pkg-config
+    ];
+    buildInputs = [
+      vips.dev
+    ];
+    npmDepsHash = "sha256-eD7hyeIcSL0nLcmBE5+gDJcjT+LdUaqIZ+g5sPcn8HQ=";
+    npmFlags = [ "--loglevel=verbose" ];
+    dontNpmBuild = true;
+    postInstall = ''
+      # it would be neater if this were a 'ln -s', but this is not possible
+      # because common/sources/notificationService.js has a circular dependency
+      # back on DocService
+      cp -r ${common}/lib/node_modules/common $out/lib/node_modules/Common
+      ln -s $out/lib/node_modules/coauthoring $out/lib/node_modules/DocService
+    '';
+  });
+  fileconverter = buildNpmPackage (finalAttrs: {
+    name = "euro-office-server-FileConverter";
+    src = server-src;
+
+    sourceRoot = "${finalAttrs.src.name}/FileConverter";
+
+    npmDepsHash = "sha256-zGLZBbQYV2z0HgQKISKVhclRKbMB8RYEX13H0mB6qJw=";
+
+    dontNpmBuild = true;
+
+    postInstall = ''
+      ln -s ${common}/lib/node_modules/common $out/lib/node_modules/Common
+      ln -s ${docservice}/lib/node_modules/coauthoring $out/lib/node_modules/DocService
+    '';
+  });


There's a good argument to be made for moving these into separate packages, or at least separate files. This is what we did for stalwart (originally separate files, subsequently separate packages).

Pandapip1 · 2026-04-11T22:39:23Z

Also: if x2t-with-fonts-and-themes is shared between euro-office and onlyoffice, then that's a pretty good reason on its own to bring it out into its own package.

Pandapip1 · 2026-04-12T03:19:36Z

+      # it would be neater if this were a 'ln -s', but this is not possible
+      # because common/sources/notificationService.js has a circular dependency
+      # back on DocService
+      cp -r ${common}/lib/node_modules/common $out/lib/node_modules/Common
+      ln -s $out/lib/node_modules/coauthoring $out/lib/node_modules/DocService


Opened Euro-Office/server#17 which should resolve this issue and allow for proper symlinking

Pandapip1 · 2026-04-12T03:29:48Z

+    postInstall = ''
+      ln -s ${common}/lib/node_modules/common $out/lib/node_modules/Common
+      ln -s ${docservice}/lib/node_modules/coauthoring $out/lib/node_modules/DocService
+    '';


Euro-Office/server#17 should eliminate the need for this.

onny · 2026-06-15T09:46:20Z

updated to 9.3.1

Thatoo · 2026-06-16T08:53:34Z

Hi,
Will it be possible to backport it to stable 26.04?

onny force-pushed the eu-office-init branch from 583d75d to e0f99b8 Compare March 30, 2026 09:05

onny force-pushed the eu-office-init branch from e0f99b8 to b035af5 Compare March 30, 2026 09:30

onny marked this pull request as ready for review March 30, 2026 09:31

nixpkgs-ci Bot requested a review from raboof March 30, 2026 09:36

nixpkgs-ci Bot added 8.has: module (update) This PR changes an existing module in `nixos/` and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 30, 2026

SuperSandro2000 reviewed Mar 30, 2026

View reviewed changes

Comment thread pkgs/by-name/eu/euro-office-documentserver/package.nix Outdated

onny force-pushed the eu-office-init branch 2 times, most recently from 3749928 to c91e0d1 Compare March 31, 2026 08:33

onny requested a review from SuperSandro2000 March 31, 2026 08:40

onny force-pushed the eu-office-init branch 2 times, most recently from 9d32cdd to bea3690 Compare March 31, 2026 09:27

dotlambda reviewed Apr 3, 2026

View reviewed changes

Pandapip1 suggested changes Apr 11, 2026

View reviewed changes

Pandapip1 reviewed Apr 12, 2026

View reviewed changes

onny changed the title ~~euro-office-documentserver: init at 0-unstable-2026-03-27~~ euro-office-documentserver: init at 0-unstable-2026-04-08 Apr 15, 2026

onny force-pushed the eu-office-init branch from 5296fcb to 97a8abe Compare April 15, 2026 08:51

nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 15, 2026

Pandapip1 mentioned this pull request Apr 15, 2026

Unwritten style guides should be written #387072

Open

onny changed the title ~~euro-office-documentserver: init at 0-unstable-2026-04-08~~ euro-office-documentserver: init at 9.3.1 Jun 15, 2026

euro-office-documentserver: init at 9.3.1

1482b2e

onny added 2 commits June 15, 2026 11:45

nixos/tests/onlyoffice: add package parameter

e2af4eb

x2t: add mainProgram

e60ca75

onny force-pushed the eu-office-init branch from 97a8abe to e60ca75 Compare June 15, 2026 09:46

	ExecStart = "${lib.getExe cfg.package.fhs} ${cfg.package.fileconverter}/bin/fileconverter";
	ExecStart = "${lib.getExe cfg.package.fhs} ${lib.getExe cfg.package.fileconverter}";

	cp ${x2t.components.sdkjs}/slide/themes/src/* working
	ln -s ${x2t.components.sdkjs}/slide/themes/src/* working

	${lndir}/bin/lndir -silent ${x2t.components.web-apps} $out/var/www/onlyoffice/documentserver/web-apps
	${lib.getExe lndir} -silent ${x2t.components.web-apps} $out/var/www/onlyoffice/documentserver/web-apps

	${x2t.components.allfontsgen}/bin/allfontsgen \
	${lib.getExe x2t.components.allfontsgen} \

Uh oh!

Uh oh!

Conversation

onny commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

Uh oh!

onny commented Mar 31, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

raboof commented Apr 3, 2026

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pandapip1 commented Apr 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

onny commented Jun 15, 2026

Uh oh!

Thatoo commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

onny commented Mar 30, 2026 •

edited

Loading