[19.0][MIG] despatch_advice_import: Migration to 19.0#1332
Conversation
OCA-git-bot
added
series:19.0
mod:despatch_advice_import
yankinmax
force-pushed
the
19.0-mig-despatch_advice_import
branch
from
133df4e to
d4ac9f8
Compare
yankinmax
force-pushed
the
19.0-mig-despatch_advice_import
branch
from
d4ac9f8 to
1662210
Compare
yankinmax
force-pushed
the
19.0-mig-despatch_advice_import
branch
from
1662210 to
d27323a
Compare
yankinmax
force-pushed
the
19.0-mig-despatch_advice_import
branch
2 times, most recently
from
a4d9299 to
e101f20
Compare
yankinmax
force-pushed
the
19.0-mig-despatch_advice_import
branch
from
e101f20 to
4538270
Compare
|
Hello @OCA/edi-maintainers can you pls take a look and possibly trigger merge? |
| @@ -1,2 +0,0 @@ | |||
| The migration of this module from 10.0 to 16.0 was financially supported | |||
… larger than the reserved quantity
Currently translated at 100.0% (35 of 35 strings) Translation: edi-16.0/edi-16.0-despatch_advice_import Translate-URL: https://translation.odoo-community.org/projects/edi-16-0/edi-16-0-despatch_advice_import/it/
- Fix cancellation of backorder moves with stock_picking_restrict_cancel_printed module - Always skip backorder wizard when validating the picking - Don't call validate when all moves are canceled
yankinmax
force-pushed
the
19.0-mig-despatch_advice_import
branch
from
4538270 to
e14ad39
Compare
| self._process_picking_done(lines[0].move_ids[0]) | ||
|
|
||
| def _process_picking_done(self, move: models.Model): | ||
| """Validate the receipt once all line-level changes are applied. | ||
|
|
||
| :param move: A stock move belonging to the picking that should be validated. | ||
| :return: True when the picking only contains canceled moves, else None. | ||
| """ | ||
| picking = move.picking_id | ||
| if all(line.state == "cancel" for line in picking.move_ids): | ||
| return True | ||
| # skip backorder wizard | ||
| picking.with_context( | ||
| skip_immediate=True, skip_backorder=True, skip_sms=True, skip_expired=True | ||
| ).button_validate() |
There was a problem hiding this comment.
We do not want to validate the incoming picking on the reception of despatch advice. I'm not sure if this must be configurable in the module or if it just shouldn't be here at all.
If that is really needed, IMO we should have a "post process hook" in this module that can be redefined in another module to process the picking as done.
There was a problem hiding this comment.
There have been changes in the migration commit to v16 that are out of the scope of the migration and that should be reverted. Validing the picking makes no sense and some other features like having one picking per reception date seems to have been lost
There was a problem hiding this comment.
Hello @jbaudoux I see your point.
Can you probably specify the workflow of this module as I just did a technical migration and completely not familiar with the module itself?
That way I could revert to the main ideas of the module.
14 participants
Depends on: