[19.0][MIG] purchase_order_import: Migration to 19.0 by yankinmax · Pull Request #1335 · OCA/edi

yankinmax · 2026-04-27T16:04:35Z

Depends on:

[19.0][MIG] pdf_xml_attachment: Migration to 19.0 reporting-engine#1157

yankinmax · 2026-04-28T12:42:47Z

Hello @vvrossem @ivantodorovich
Can you pls take a look?

yankinmax · 2026-04-29T11:28:01Z

Hello @OCA/edi-maintainers can you pls take a look and possibly trigger merge?

simahawk · 2026-05-04T15:01:25Z

@@ -0,0 +1,2 @@
+from . import common


never import common files here

simahawk · 2026-05-04T15:01:47Z

+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))


BaseCommon already disables tracking if I'm not wrong

simahawk · 2026-05-04T15:02:39Z

+
+
+class OrderResponseImportWizard(models.TransientModel):
+    _name = "order.response.import.wizard"


Suggested change

_name = "order.response.import.wizard"

_name = "purchase.order.response.import.wizard"

simahawk · 2026-05-04T15:05:38Z

+        purchase_order.button_approve()
+
+    @api.model
+    def _process_conditional(


this method looks too big

simahawk · 2026-05-04T15:08:01Z

+            vals["incoterm_id"] = incoterm.id
+        return vals
+
+    def update_order_lines(


quite big...

ivantodorovich · 2026-05-19T15:30:58Z

+            "product_qty": import_line.get("qty") or 1.0,
+            "product_uom_id": uom.id,
+        }
+        vals.update(polo.play_onchanges(vals, ["product_id"]))


Suggested change

vals.update(polo.play_onchanges(vals, ["product_id"]))

I believe we can drop this, as all relevant fields have been moved to computed fields in core.
Then, we can drop the onchange_helper dependency

I see your point and agree.

onchange_helper as dependency is only needed for this call vals.update(polo.play_onchanges(vals, ["product_id"]))

In Odoo 19, pucrhase.order.line::create calls _prepare_add_missing_fields which is doing the same:

@api.model def _prepare_add_missing_fields(self, values): """ Deduce missing required fields from the onchange """ res = {} onchange_fields = ['name', 'price_unit', 'product_qty', 'product_uom_id', 'tax_ids', 'date_planned'] if values.get('order_id') and values.get('product_id') and any(f not in values for f in onchange_fields): line = self.new(values) line.onchange_product_id() for field in onchange_fields: if field not in values: res[field] = line._fields[field].convert_to_write(line[field], line) return res

Leave imported price_unit, product_qty and product_uom_id.

…ort_ubl and purchase_order_ubl

because we want to have access to the code of the modules that inherit business.document.import

'text/xml'

PEP8 fix

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

Rename __openerp__.py to __manifest__.py and set installable to False

… module Fix spelling mistake and other remarks on README by Tarteo

Add ubl invoice generation option in accounting config page

… has visible discounts Code improvements in sale_order_import Add unit tests in sale_order_import Use display_name instead of name_get()[0][1]

…iness document is imported in the right company

Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.

the method play_onchange in server-tools/onchange_helper only returns the changed keys in the dictionary it receives as first arguement. The code in account_invoice_import, purchase_order_import and sale_order_import was written as if all the keys were returned. Maybe the behavior of play_onchange was updated in a recent version, but this nevertheless needs fixing in this module. This should fix the unit tests which are red on this branch.

The ORderResponce document allows a supplier to communicate the ack and the confirmation of an Order documnet. Depending of its content, the PO will be cancelled or confirmed. If the OrderResponse document contains some amended line, the import process will update the picking to reflect the changes

yankinmax · 2026-05-20T07:51:54Z

Hello @simahawk @ivantodorovich your suggestions are applied.
Can you pls trigger merge here?

jbaudoux

LG but I wouldn't rename the wizard files as it prevents to see the migration changes and won't be convenient for later porting imp/fixes

yankinmax · 2026-05-20T08:49:48Z

LG but I wouldn't rename the wizard files as it prevents to see the migration changes and won't be convenient for later porting imp/fixes

Can you pls check if this is ok for you now?

cyrilmanuel · 2026-05-27T07:18:02Z

hi @jbaudoux can i ask you a quick review :P

OCA-git-bot added series:19.0 mod:purchase_order_import Module purchase_order_import labels Apr 27, 2026

yankinmax force-pushed the 19.0-mig-purchase_order_import branch 2 times, most recently from 99c0744 to deccd3f Compare April 28, 2026 06:18

yankinmax mentioned this pull request Apr 28, 2026

[19.0][MIG] purchase_order_import_ubl: Migration to 19.0 #1336

Open

2 tasks

yankinmax force-pushed the 19.0-mig-purchase_order_import branch from deccd3f to 22d3f77 Compare April 28, 2026 12:40

ivantodorovich reviewed Apr 28, 2026

View reviewed changes

Comment thread purchase_order_import/tests/common.py Outdated

Comment thread purchase_order_import/tests/test_order_response_import_wizard.py Outdated

ivantodorovich reviewed Apr 28, 2026

View reviewed changes

Comment thread purchase_order_import/tests/common.py Outdated

Comment thread purchase_order_import/wizard/purchase_order_import_wizard.py Outdated

Comment thread purchase_order_import/wizard/purchase_order_import_wizard.py Outdated

yankinmax force-pushed the 19.0-mig-purchase_order_import branch from 22d3f77 to 5dc53fb Compare April 29, 2026 07:10

cyrilmanuel approved these changes Apr 29, 2026

View reviewed changes

Comment thread test-requirements.txt Outdated

yankinmax force-pushed the 19.0-mig-purchase_order_import branch from 5dc53fb to 1fca1af Compare April 29, 2026 11:17

simahawk requested changes May 4, 2026

View reviewed changes

ivantodorovich reviewed May 19, 2026

View reviewed changes

alexis-via and others added 15 commits May 20, 2026 10:45

Initial check-in of modules purchase_order_import, purchase_order_imp…

c0e3206

…ort_ubl and purchase_order_ubl

FIX Don't use _inherit = ['business.document.import']

a2686c2

because we want to have access to the code of the modules that inherit business.document.import

[IMP] handle the case where the xml file is generated with mime type

2260522

'text/xml'

Add support for extraction + matching on website

ef618eb

PEP8 fix

8.0 Add support for partner bank matching on invoice update (OCA#6)

e4849ab

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

Prepare v10 branch

3d87717

Rename __openerp__.py to __manifest__.py and set installable to False

Continue port of modules for v10.0, in particular sale_order_import_*…

e90d482

… module Fix spelling mistake and other remarks on README by Tarteo

Port purchase_order_import* to v10.0

9cb9a29

Add ubl invoice generation option in accounting config page

Fix import of sale order with price_source='pricelist' when pricelist…

7f28716

… has visible discounts Code improvements in sale_order_import Add unit tests in sale_order_import Use display_name instead of name_get()[0][1]

Check the VAT number of the destination partner, to make sure the bus…

1a32565

…iness document is imported in the right company

Update translation files

a041c0b

Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.

[FIX] remove method defined twice

3d0d777

[FIX] purchase_order_import: missing price_unit on line

dc49325

lmignon and others added 4 commits May 20, 2026 10:45

[IMP] purchase_order_import: log exception in case of parsing error

4cd95bf

FIX purchase_order_import_*: version number after manual merge

21df54c

[IMP] purchase_order_import: pre-commit auto fixes

c32bb36

[MIG] purchase_order_import: Migration to 19.0

9321421

yankinmax force-pushed the 19.0-mig-purchase_order_import branch from 0e4d197 to 9321421 Compare May 20, 2026 07:45

jbaudoux reviewed May 20, 2026

View reviewed changes

fixup! [MIG] purchase_order_import: Migration to 19.0

a88de77



		class OrderResponseImportWizard(models.TransientModel):
		_name = "order.response.import.wizard"

	_name = "order.response.import.wizard"
	_name = "purchase.order.response.import.wizard"

Uh oh!

Conversation

yankinmax commented Apr 27, 2026 • edited by pedrobaeza Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yankinmax commented Apr 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yankinmax commented Apr 29, 2026

Uh oh!

simahawk May 4, 2026

Choose a reason for hiding this comment

Uh oh!

simahawk May 4, 2026

Choose a reason for hiding this comment

Uh oh!

simahawk May 4, 2026

Choose a reason for hiding this comment

Uh oh!

simahawk May 4, 2026

Choose a reason for hiding this comment

Uh oh!

simahawk May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ivantodorovich May 19, 2026

Choose a reason for hiding this comment

Uh oh!

yankinmax May 20, 2026

Choose a reason for hiding this comment

Uh oh!

yankinmax commented May 20, 2026

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented May 20, 2026

Uh oh!

cyrilmanuel commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

yankinmax commented Apr 27, 2026 •

edited by pedrobaeza

Loading