Skip to content

[18.0][IMP] sale_order_import: allow creating invoice/delivery partners on the fly#1341

Open
SilvioC2C wants to merge 1 commit into
OCA:18.0from
camptocamp:18.0-imp-sale_order_import
Open

[18.0][IMP] sale_order_import: allow creating invoice/delivery partners on the fly#1341
SilvioC2C wants to merge 1 commit into
OCA:18.0from
camptocamp:18.0-imp-sale_order_import

Conversation

@SilvioC2C
Copy link
Copy Markdown
Contributor

@SilvioC2C SilvioC2C commented May 13, 2026

No description provided.

simahawk
simahawk requested changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall, minor remarks

Comment thread sale_order_import/wizard/sale_order_import.py
Comment thread sale_order_import/wizard/sale_order_import.py
Comment thread sale_order_import/wizard/sale_order_import.py
Comment thread sale_order_import/tests/test_order_import.py
simahawk
simahawk approved these changes May 14, 2026
View reviewed changes
Comment thread sale_order_import/wizard/sale_order_import.py
@SilvioC2C SilvioC2C force-pushed the 18.0-imp-sale_order_import branch from e4300de to c34c470 Compare May 14, 2026 13:56
@SilvioC2C
Copy link
Copy Markdown
Contributor Author

SilvioC2C commented May 14, 2026

@simahawk I added a small fix (method _create_missing_partner_vals_cleanup()), did some lesser refactoring (mostly type annotations) and updated the tests (checking a few more fields in the newly created partners), so I directly squashed the changes into the existing commit and force-pushed instead of using a fixup commit.

@SilvioC2C SilvioC2C changed the title [IMP] sale_order_import: allow creating invoice/delivery partners on the fly [18.0][IMP] sale_order_import: allow creating invoice/delivery partners on the fly May 14, 2026
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 22, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 22, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

+2 more reviewers

@henrybackman henrybackman henrybackman approved these changes

@vvrossem vvrossem vvrossem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:sale_order_import Module sale_order_import ready to merge series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SilvioC2C @OCA-git-bot @simahawk @henrybackman @vvrossem