18.0 fix account_invoice_import_simple_pdf: optional invoice date#1344
Open
jans23 wants to merge 1 commit into
Open
18.0 fix account_invoice_import_simple_pdf: optional invoice date#1344jans23 wants to merge 1 commit into
jans23 wants to merge 1 commit into
Conversation
Contributor
|
Hi @alexis-via, |
OCA-git-bot
added
series:18.0
mod:account_invoice_import_simple_pdf
jans23
force-pushed
the
18.0-fix-account_invoice_import_simple_pdf-optional-date
branch
from
d1b351d to
c14d712
Compare
hbrunn
approved these changes
May 25, 2026
Member
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
looks fine, please add a test though proving that invoice creation works with and without date
jans23
force-pushed
the
18.0-fix-account_invoice_import_simple_pdf-optional-date
branch
from
c14d712 to
e882c18
Compare
Member
|
thanks! |
Author
|
@alexis-via please have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 15.0 this module didn't require an invoice date to be set and to be extracted. This fix makes the invoice date optional on 18.0. This is useful for invoices from which their date can't be extracted (e.g. because their date format doesn't match any of the supported patterns).
@hbrunn