You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A heads-up on the red test jobs: the module installs cleanly and all 71 tests pass — both portal tours log TOUR … SUCCEEDED. The build fails on the log-error gate, which trips on a Chrome teardown warning from the two HttpCase tours:
These are unreaped Chrome child processes in the CI container during HttpCase cleanup (odoo/tests/common.py), not a test failure — the tours themselves succeed. Since oca-ci fails the build on any warning (OCA/oca-ci#89), this blocks it.
Is this a known issue with browser tours in the current image (possibly Chrome-version related, cf. OCA/oca-ci#122)? Happy to adjust the tests if you'd prefer a different approach (e.g. HTTP-level checks instead of full browser tours). Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
document_page_portalto 18.0. Part of #499.Changes during migration (beyond the mechanical pass)
<data>node;t-raw→t-out; Bootstrap 4 → 5 classes.views/assets.xmlto the manifestassetskey.web_tour.toursregistry API; the Python tests now usestart_tour.knowledge.group_document_user→document_knowledge.group_document_user.placeholder_countpattern (it was rendering hidden).portal.portal_record_layoutwith an inline card./web#…to/odoo/document.page/<id>.A separate
[IMP]commit improves the README (clearer DESCRIPTION/USAGE, fixed CREDITS link).Tested locally on 18.0: the module installs cleanly and both portal tours pass in a headless browser.