Skip to content

[MIG] base_dav: Migration to 17.0#269

Closed
jaydeep32 wants to merge 60 commits into
OCA:17.0from
archeti-org:17.0-mig-base_dav
Closed

[MIG] base_dav: Migration to 17.0#269
jaydeep32 wants to merge 60 commits into
OCA:17.0from
archeti-org:17.0-mig-base_dav

Conversation

@jaydeep32

@jaydeep32 jaydeep32 commented Feb 14, 2024

Copy link
Copy Markdown

To install and use this module, use the right version of radicale==2.1.12 python package.
This PR for this #254

jaydeep32 and others added 30 commits February 14, 2024 11:31
Currently translated at 100.0% (62 of 62 strings)

Translation: server-backend-17.0/server-backend-17.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-17-0/server-backend-17-0-base_user_role/es/
Currently translated at 100.0% (62 of 62 strings)

Translation: server-backend-17.0/server-backend-17.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-17-0/server-backend-17-0-base_user_role/it/
Currently translated at 100.0% (11 of 11 strings)

Translation: server-backend-14.0/server-backend-14.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/it/
Issue found on logout / relogin.
The user groups were applied correctly, but the main menu showed apps
the user did not have access to.

This was related to the menu caching mechanisn, that was disabled here.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-14.0/server-backend-14.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/
Currently translated at 90.9% (10 of 11 strings)

Translation: server-backend-14.0/server-backend-14.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-14-0/server-backend-14-0-base_user_role_company/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-16.0/server-backend-16.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role_company
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role_company/es/
@jaydeep32

Copy link
Copy Markdown
Author

Hello @dreispt Now is it ok? I have added those commits from 11.0 to this one.

Comment thread base_dav/__manifest__.py
],
"external_dependencies": {
"python": ["radicale"],
"python": ["radicale==2.1.12"],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be >= ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I use this specific module version because this module's code is only compatible with this 2.1.12 or older version of radical. If you check this #254 issue here, @AquaMCU has mentioned that he is having this strange error in the log,
so I solved that by changing the module version to radicale==2.1.12.

Also, if possible, can we add @AquaMCU to the discussion since he is the one who has migrated the module?
Actually, he was not able to create PR, so I simply made that for him

if not self:
return self.env["unknown"]
self.ensure_one()
self = self.with_user(SUPERUSER_ID)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raises security concerns, why is this required?

@amh-mw amh-mw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaydeep32 This doesn't look right. Why are there commits specific to the base_user_role_company module? I second @dreispt 's comment that you need to start fresh with a clean local folder and follow the steps in the migration documentation.

@dreispt

dreispt commented Mar 20, 2024

Copy link
Copy Markdown
Member

@jaydeep32 Great work, you made it!
Now I can see your migration changes.
I made a couple of questions, thanks.

@dreispt

dreispt commented Mar 20, 2024

Copy link
Copy Markdown
Member

@amh-mw You're right.
@jaydeep32 I ran the migration process myself and applied your changes, here #276
This has the correct history.

I suggest you fetch my branch, git reset this branch to it, and continue from there.

@dreispt dreispt linked an issue Mar 20, 2024 that may be closed by this pull request

@flotho flotho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flotho

flotho commented Jul 11, 2024

Copy link
Copy Markdown
Member

thanks for this PR. I thinks some ACL are missing for http://oca-server-backend-17-0-pr269-360893ee9167.runboat.odoo-community.org/web?debug=1#id=1&cids=1&menu_id=65&action=77&model=dav.collection&view_type=form image

mostly impossible to configure this in the UI

@eLBati

eLBati commented Jul 29, 2024

Copy link
Copy Markdown
Member

Should we move to #276 ?

@josselex

josselex commented Oct 5, 2024

Copy link
Copy Markdown

Is there any progress on it? Maybe even upgrading it to Odoo 18? Can we sponsor this?

SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-backend (12.0)
@github-actions

github-actions Bot commented Feb 2, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 2, 2025
@github-actions github-actions Bot closed this Mar 9, 2025
@Katulos

Katulos commented Dec 12, 2025

Copy link
Copy Markdown

Is there any progress on it? Maybe even upgrading it to Odoo 18? Can we sponsor this?

Hello.
Porting to 18.0 is no problem. But as we see, OCA isn't accepting pull requests.

@Aldeigja

Aldeigja commented Mar 6, 2026

Copy link
Copy Markdown

Is there any progress on it? Maybe even upgrading it to Odoo 18? Can we sponsor this?

@josselex Please take a look at #431 functional testing and code review would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

base_dav dead?