Skip to content

Fix (most) template formatting issues in phasor dynamics#410

Merged
pelesh merged 2 commits into
developfrom
PhilipFackler/pd-templates
Jun 5, 2026
Merged

Fix (most) template formatting issues in phasor dynamics#410
pelesh merged 2 commits into
developfrom
PhilipFackler/pd-templates

Conversation

@PhilipFackler
Copy link
Copy Markdown
Collaborator

@PhilipFackler PhilipFackler commented May 20, 2026

Description

See #366

Proposed changes

Use snake_case for template parameters. and UpperCamelT for public interface types.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A?] I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@PhilipFackler PhilipFackler force-pushed the PhilipFackler/pd-templates branch from a21e523 to 44bc562 Compare May 20, 2026 21:17
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/pd-templates branch 2 times, most recently from 17cbc2f to 6f7b6e5 Compare June 4, 2026 20:17
@PhilipFackler PhilipFackler marked this pull request as ready for review June 4, 2026 20:18
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/pd-templates branch from 24d8e93 to 81d8870 Compare June 4, 2026 20:19
@PhilipFackler
Copy link
Copy Markdown
Collaborator Author

Note that this updates the style guidelines in CONTRIBUTING.md but updates the code only in PhasorDynamics.

@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Jun 5, 2026

Need to resolve conflicts, otherwise good to merge.

Comment thread CONTRIBUTING.md Outdated
Copy link
Copy Markdown
Collaborator

@nkoukpaizan nkoukpaizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

I am slightly concerned with having inconsistent formatting in other (non phasor dynamics) modules. As long as we are planning to update the others "soon", I'm good with merging.

@PhilipFackler PhilipFackler force-pushed the PhilipFackler/pd-templates branch from 81d8870 to 5cddbad Compare June 5, 2026 14:53
@pelesh pelesh merged commit 31c9474 into develop Jun 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants