Skip to content

MVA Parameter Cleanup#435

Open
lukelowry wants to merge 2 commits into
developfrom
lukel/mva-consistancy-dev
Open

MVA Parameter Cleanup#435
lukelowry wants to merge 2 commits into
developfrom
lukel/mva-consistancy-dev

Conversation

@lukelowry
Copy link
Copy Markdown
Collaborator

Description

Use mva consistently as the JSON-facing key for synchronous machine MVA base parameters.

Proposed changes

  • Replaces synchronous machine mva_base JSON keys with mva.
  • Updates synchronous machine data enums, tests, and example cases to use the new key.
  • Updates the PhasorDynamics input format documentation for the renamed parameter.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

More consistent style, but this is also a cleanup in preparation for a more general power base conversion API, which needs to be consistent as we introduce more intra-model initialization (especially for REECA, REECB, REPCA, and HYGOV)

@lukelowry lukelowry force-pushed the lukel/mva-consistancy-dev branch from 0e062e1 to cf8d303 Compare June 2, 2026 19:52
@lukelowry lukelowry requested a review from pelesh June 2, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant