Conversation
dbaston
requested changes
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fix apply
pythonappendguard to the accessors that missed it, similar to how it was handled in other functions.Reproduced on 3.13.3 and master.
Fixed
swig/include/python/gdal_python.i-%extend GDALRasterBandShadow:Band.GetSampleOverview()- SIGSEGVBand.GetDefaultRAT()- SIGSEGVBand.GetRasterColorTable()- SIGSEGV / garbageBand.GetColorTable()- alias of the aboveBand.GetDataset()- reads freed memory, different error on each runswig/include/python/gdal_python.i-%extend GDALDatasetShadow:Dataset.GetFieldDomain()- SIGSEGV / garbageDataset.GetStyleTable()- SIGSEGV / garbageswig/include/python/ogr_python.i-%extend OGRLayerShadow:Layer.GetSpatialFilter()- SIGSEGVLayer.GetStyleTable()- SIGSEGV / garbageTests
Added 8 tests in
autotest/gcore/basic_test.py, similar to the existingtest_*_use_after_dataset_closepattern:test_sample_ovr_band_use_after_dataset_closetest_rat_use_after_dataset_closetest_color_table_use_after_dataset_closetest_field_domain_use_after_dataset_closetest_style_table_use_after_dataset_closetest_layer_style_table_use_after_dataset_closetest_spatial_filter_use_after_dataset_closetest_band_dataset_use_after_dataset_closeWhat are related issues/pull requests?
AI tool usage
Tasklist
Environment
Provide environment details, if relevant: