Skip to content

Add deck-specific EoP how-to-play instructions - #3488

Merged
sydseter merged 2 commits into
OWASP:masterfrom
dedsec-terminal:fix/3482-eop-how-to-play
Sep 12, 2026
Merged

Add deck-specific EoP how-to-play instructions#3488
sydseter merged 2 commits into
OWASP:masterfrom
dedsec-terminal:fix/3482-eop-how-to-play

Conversation

@dedsec-terminal

@dedsec-terminal dedsec-terminal commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the missing Elevation of Privilege instructions to the existing How to play page using the canonical EoP 5.0 source text, then makes each deck's card-page target explicit in decks.yaml. EoP cards now link directly to the new How-to-play-EoP section, while the other browsable decks continue to use the general instructions.

The link is loaded server-side for every card route and passed to the shared CardFound component. Deck configuration validation and focused accessor tests cover the new required field and fallback behavior.

Also adds Swaraj Singh to the volunteer list, as invited by the maintainer after assignment.

No new game mechanics or requirements were generated; the EoP rules are a presentation-only transcription of source/eop-cards-5.0-en.yaml entries T00160 through T00360.

Resolved or fixed issue: #3482

Verification

  • corepack pnpm exec vitest run: 23 files, 250 tests passed
  • corepack pnpm run lint: passed
  • git diff --check: passed
  • Rendered integration check: the play page contains id="How-to-play-EoP" and the EoP TA3 card page contains the matching href="/how-to-play#How-to-play-EoP"
  • GitHub Actions at the current head: website build, converter tests, COPI tests, dependency review, and qlty all passed

AI Tool Disclosure

  • My contribution does not include any AI-generated content
  • My contribution includes AI-generated content, as disclosed below:
    • AI Tools: OpenAI Codex Desktop
    • LLMs and versions: GPT-5.6 Sol
    • Prompts: Trace issue How to play link for EoP #3482 through the canonical EoP source, deck configuration, shared card component, and all card routes; transcribe only the existing EoP rules; add the maintainer-authorized contributor entry; add focused tests; and verify the rendered anchor and card target.

Affirmation

  • My code follows the CONTRIBUTING.md guidelines

Closes #3482

@dedsec-terminal
dedsec-terminal marked this pull request as ready for review September 11, 2026 14:48
Copilot AI lite review requested due to automatic review settings September 11, 2026 14:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Adds canonical EoP 5.0 instructions and deck-specific how-to-play links for card pages.

Changes:

  • Adds EoP instructions and deck link configuration.
  • Propagates links through card routes and shared components.
  • Adds validation tests and contributor attribution.
File summaries
File Description
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/+page.svelte Passes the configured link to cards.
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/+page.server.ts Loads the deck link.
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/[version]/+page.svelte Passes the configured link.
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/[version]/+page.server.ts Loads the deck link.
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/[version]/[lang]/+page.svelte Passes the configured link.
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/[version]/[lang]/+page.server.ts Loads the deck link.
cornucopia.owasp.org/src/routes/cards/[card]/+page.svelte Passes the configured link.
cornucopia.owasp.org/src/routes/cards/[card]/+page.server.ts Loads the deck link.
cornucopia.owasp.org/src/lib/services/deckConfigService.ts Adds validation, lookup, and fallback behavior.
cornucopia.owasp.org/src/lib/services/deckConfigService.test.ts Tests configuration and accessor behavior.
cornucopia.owasp.org/src/lib/components/cardFound.svelte Renders the configured destination.
cornucopia.owasp.org/decks.yaml Configures links for each deck.
cornucopia.owasp.org/data/website/pages/tribute/en/index.md Adds the contributor.
cornucopia.owasp.org/data/website/pages/play/en/index.md Adds EoP instructions.
Review details
  • Files reviewed: 14/14 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sydseter sydseter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions!

@sydseter

Copy link
Copy Markdown
Collaborator

@dedsec-terminal Your commits mist have a verified signature, please set up commit signing and redo the commit.

Signed-off-by: dedsec-terminal <dedsec.terminal@gmail.com>
@dedsec-terminal

Copy link
Copy Markdown
Contributor Author

Commit has been signed with my SSH signing key and updated via force-push. It now shows as verified.

@sydseter
sydseter merged commit 9e919a2 into OWASP:master Sep 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to play link for EoP

3 participants