Add deck-specific EoP how-to-play instructions - #3488
Merged
Conversation
dedsec-terminal
force-pushed
the
fix/3482-eop-how-to-play
branch
from
September 11, 2026 14:41
d455272 to
360afff
Compare
dedsec-terminal
marked this pull request as ready for review
September 11, 2026 14:48
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Adds canonical EoP 5.0 instructions and deck-specific how-to-play links for card pages.
Changes:
- Adds EoP instructions and deck link configuration.
- Propagates links through card routes and shared components.
- Adds validation tests and contributor attribution.
File summaries
| File | Description |
|---|---|
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/+page.svelte |
Passes the configured link to cards. |
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/+page.server.ts |
Loads the deck link. |
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/[version]/+page.svelte |
Passes the configured link. |
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/[version]/+page.server.ts |
Loads the deck link. |
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/[version]/[lang]/+page.svelte |
Passes the configured link. |
cornucopia.owasp.org/src/routes/edition/[edition]/[card]/[version]/[lang]/+page.server.ts |
Loads the deck link. |
cornucopia.owasp.org/src/routes/cards/[card]/+page.svelte |
Passes the configured link. |
cornucopia.owasp.org/src/routes/cards/[card]/+page.server.ts |
Loads the deck link. |
cornucopia.owasp.org/src/lib/services/deckConfigService.ts |
Adds validation, lookup, and fallback behavior. |
cornucopia.owasp.org/src/lib/services/deckConfigService.test.ts |
Tests configuration and accessor behavior. |
cornucopia.owasp.org/src/lib/components/cardFound.svelte |
Renders the configured destination. |
cornucopia.owasp.org/decks.yaml |
Configures links for each deck. |
cornucopia.owasp.org/data/website/pages/tribute/en/index.md |
Adds the contributor. |
cornucopia.owasp.org/data/website/pages/play/en/index.md |
Adds EoP instructions. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dedsec-terminal
force-pushed
the
fix/3482-eop-how-to-play
branch
from
September 11, 2026 19:28
d75b391 to
cb0eca9
Compare
sydseter
approved these changes
Sep 11, 2026
sydseter
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contributions!
Collaborator
|
@dedsec-terminal Your commits mist have a verified signature, please set up commit signing and redo the commit. |
Signed-off-by: dedsec-terminal <dedsec.terminal@gmail.com>
dedsec-terminal
force-pushed
the
fix/3482-eop-how-to-play
branch
from
September 11, 2026 20:43
cb0eca9 to
c7604bd
Compare
Contributor
Author
|
Commit has been signed with my SSH signing key and updated via force-push. It now shows as verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the missing Elevation of Privilege instructions to the existing How to play page using the canonical EoP 5.0 source text, then makes each deck's card-page target explicit in decks.yaml. EoP cards now link directly to the new How-to-play-EoP section, while the other browsable decks continue to use the general instructions.
The link is loaded server-side for every card route and passed to the shared CardFound component. Deck configuration validation and focused accessor tests cover the new required field and fallback behavior.
Also adds Swaraj Singh to the volunteer list, as invited by the maintainer after assignment.
No new game mechanics or requirements were generated; the EoP rules are a presentation-only transcription of source/eop-cards-5.0-en.yaml entries T00160 through T00360.
Resolved or fixed issue: #3482
Verification
AI Tool Disclosure
Affirmation
Closes #3482