Skip to content

feat: testing #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oleksandr-codefresh wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: testing #1220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
106f8eb
Add conditional pod cleanup in CompleteScriptAsync method
oleksandr-codefresh May 11, 2026
5b09aa5
Update markAsInitialised function to use configurationDirectory for i…
oleksandr-codefresh May 11, 2026
095118c
added more logs
oleksandr-codefresh May 11, 2026
ad40eef
keep volume for failed scripts when debug left
oleksandr-codefresh May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docker/kubernetes-agent-tentacle/scripts/configure-and-run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ applicationsDirectory=/home/Octopus/Applications
if [[ -n "$TentacleApplications" ]]; then
applicationsDirectory="$TentacleApplications"
fi

echo "Creating config directory"
echo "Permissions for $configurationDirectory:"
ls -lan / | grep etc
mkdir -p $configurationDirectory
mkdir -p $applicationsDirectory

Expand Down Expand Up @@ -414,7 +416,7 @@ function setPollingProxy() {

function markAsInitialised() {
# There is a startupProbe which checks for this file
mkdir -p /etc/octopus && touch /etc/octopus/initialized
mkdir -p "$configurationDirectory" && touch "$configurationDirectory/initialized"
}

setupVariablesForRegistrationCheck
Expand Down
7 changes: 6 additions & 1 deletion source/Octopus.Tentacle/Services/Scripts/Kubernetes/KubernetesScriptServiceV1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,12 @@ public async Task<KubernetesScriptStatusResponseV1> CancelScriptAsync(CancelKube
public async Task CompleteScriptAsync(CompleteKubernetesScriptCommandV1 command, CancellationToken cancellationToken)
{
var workspace = workspaceFactory.GetWorkspace(command.ScriptTicket, WorkspaceReadinessCheck.Skip);
await workspace.Delete(cancellationToken);

var podExitCode = podStatusProvider.TryGetTrackedScriptPod(command.ScriptTicket)?.State.ExitCode ?? 0;

// Preserve the workspace when the script pod failed so the files are available for debugging.
if (!KubernetesConfig.DisableAutomaticPodCleanup && podExitCode != 0)
await workspace.Delete(cancellationToken);

scriptLogProvider.Delete(command.ScriptTicket);
scriptPodSinceTimeStore.Delete(command.ScriptTicket);
Expand Down