[Do Not Review] Adding back in the deprecation pipeline#2684
[Do Not Review] Adding back in the deprecation pipeline#2684jadahiya-MSFT wants to merge 14 commits intomainfrom
Conversation
|
Is there a way this can be validated before it's committed? |
| command: custom | ||
| workingDir: $(PIPELINE.WORKSPACE)/microsoft-teams-library-js-pipeline/NPMFeed | ||
| verbose: false | ||
| customCommand: deprecate @microsoft/teams-js@3.0.* "Package no longer supported. Use at your own risk" |
There was a problem hiding this comment.
Can you say more about how this pipeline works? This looks like every time the pipeline runs, it deprecates all 3.0.* packages. Is that how it's supposed to work? Or is the person who runs the pipeline supposed to be able to specify what version they want to deprecate?
There was a problem hiding this comment.
Sorry this was just meant to be a draft PR to see if the new pipeline would be added into ADO. Will be modifying this so that we can specify the version/versions we wish to deprecate as a Pipeline resource going forward.
| command: custom | ||
| workingDir: $(PIPELINE.WORKSPACE)/microsoft-teams-library-js-pipeline/NPMFeed | ||
| verbose: false | ||
| customCommand: deprecate @microsoft/teams-js@3.0.* "Package no longer supported. Use at your own risk" |
There was a problem hiding this comment.
I feel like rather than needing to check in a PR each time you want to deprecate a version; it would make more sense to make the version a pipeline variable so we can edit it in ADO each time we run the pipeline.
| customCommand: deprecate @microsoft/teams-js@3.0.* "Package no longer supported. Use at your own risk" | |
| customCommand: deprecate @microsoft/teams-js@$(versionToDeprecate) "Package no longer supported. Use at your own risk" |
There was a problem hiding this comment.
Yup the plan was to make the version/versions plummed in as a pipeline resource instead of a single version. Only had it as the above since I was intending for this PR to actually just be a draft to see if it gets added to ADO correctly
For more information about how to contribute to this repo, visit this page.
Description
Main changes in the PR:
Validation
Validation performed:
Unit Tests added:
<Yes/No>
End-to-end tests added:
<Yes/No>
Additional Requirements
Change file added:
<Yes/No>
Related PRs:
Next/remaining steps:
Screenshots: