Add agent instructions and teams-js contributor skill#3032
Open
jekloudaMSFT wants to merge 7 commits intomainfrom
Open
Add agent instructions and teams-js contributor skill#3032jekloudaMSFT wants to merge 7 commits intomainfrom
jekloudaMSFT wants to merge 7 commits intomainfrom
Conversation
Contributor
size-limit report 📦
|
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
aeunms
approved these changes
Apr 28, 2026
Contributor
aeunms
left a comment
aeunms
left a comment
There was a problem hiding this comment.
Sorry it took so late to review between my OOFages! These looks fantastic, just added a couple comments with questions. Feel free to merge without changes.
| - User is building an app _with_ TeamsJS as a consumer (point them to https://learn.microsoft.com/javascript/api/overview/msteams-client) | ||
| - User asks about Teams Bot Framework or other Teams SDKs | ||
|
|
||
| ## Monorepo Structure |
Contributor
There was a problem hiding this comment.
This is probably fine for now, but if we ever end up moving things around, how do you think the agent might handle that discrepancy between these instructions?
| - Importing `{ app, authentication, pages }` must stay under the limit specified in `package.json` (uncompressed, no brotli) | ||
| - If your change exceeds this, either tree-shaking is broken or you must justify the increase in your PR | ||
|
|
||
| ### Changefiles (Beachball) |
Contributor
There was a problem hiding this comment.
maybe we could also do a cheap check if pushing where we see if they touched the relevant files to make the agent make sure the author knows they must create a changefile to make a PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
Adds instructions for GitHub Copilot and Claude as well as a skill with more details on making changes within teams-js.