Skip to content

feat(pyoaev): introduce the vulnerability endpoint (#197)#291

Merged
Megafredo merged 3 commits into
mainfrom
feat/197-introduce-the-vulnerability-api-client
Jun 23, 2026
Merged

feat(pyoaev): introduce the vulnerability endpoint (#197)#291
Megafredo merged 3 commits into
mainfrom
feat/197-introduce-the-vulnerability-api-client

Conversation

@Megafredo

@Megafredo Megafredo commented Jun 22, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Introduced a new VulnerabilityManager targeting the /vulnerabilities endpoint.
  • Added support for bulk vulnerability upsert operations through /vulnerabilities/bulk.
  • Kept the implementation aligned with the existing CVE (legacy).

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

This PR intentionally maintains the same scope and implementation model as the existing CVE client.

A separate issue, feat(pyoaev): analysis and impact of api endpoint realignment, will be created to evaluate all API endpoints that are not currently exposed by pyoaev.

The goal is to determine whether all endpoints should be made available users via client-python (pyoaev) and to assess the technical and functional impact of any further realignment before implementing any additional changes.

@Megafredo Megafredo requested review from Kakudou, guzmud and mariot June 22, 2026 06:58
@Megafredo Megafredo self-assigned this Jun 22, 2026
Copilot AI review requested due to automatic review settings June 22, 2026 06:58
@Megafredo Megafredo added the filigran team Item from the Filigran team. label Jun 22, 2026
@Megafredo Megafredo linked an issue Jun 22, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.19%. Comparing base (38e689f) to head (ee4e578).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files          53       53           
  Lines        2350     2350           
=======================================
  Hits         1720     1720           
  Misses        630      630           
Flag Coverage Δ
connectors 73.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new API client module for interacting with OpenAEV’s /vulnerabilities endpoint, mirroring the existing legacy CVE client’s bulk upsert approach.

Changes:

  • Introduced Vulnerability / VulnerabilityManager targeting /vulnerabilities.
  • Implemented bulk upsert via POST /vulnerabilities/bulk.
  • Added HTTP error wrapping using the existing @exc.on_http_error(exc.OpenAEVUpdateError) pattern.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyoaev/apis/vulnerability.py
Comment thread pyoaev/apis/vulnerability.py
Comment thread pyoaev/apis/vulnerability.py Outdated

@Kakudou Kakudou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
As you already stated it, this PR was a little fix only to match the CVE existing scope.
But was really a trigger to realised that we have work to do on the alignement of the client api and the endpoint identified in the swagger.

Great Job on both quickfixes and future work identifications!

@Megafredo Megafredo merged commit e6d3570 into main Jun 23, 2026
8 checks passed
@Megafredo Megafredo deleted the feat/197-introduce-the-vulnerability-api-client branch June 23, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: introduce the Vulnerability API client

4 participants