feat(pyoaev): introduce the vulnerability endpoint (#197)#291
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 73.19% 73.19%
=======================================
Files 53 53
Lines 2350 2350
=======================================
Hits 1720 1720
Misses 630 630
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new API client module for interacting with OpenAEV’s /vulnerabilities endpoint, mirroring the existing legacy CVE client’s bulk upsert approach.
Changes:
- Introduced
Vulnerability/VulnerabilityManagertargeting/vulnerabilities. - Implemented bulk upsert via
POST /vulnerabilities/bulk. - Added HTTP error wrapping using the existing
@exc.on_http_error(exc.OpenAEVUpdateError)pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kakudou
left a comment
There was a problem hiding this comment.
LGTM !
As you already stated it, this PR was a little fix only to match the CVE existing scope.
But was really a trigger to realised that we have work to do on the alignement of the client api and the endpoint identified in the swagger.
Great Job on both quickfixes and future work identifications!
Proposed changes
VulnerabilityManagertargeting the/vulnerabilitiesendpoint./vulnerabilities/bulk.Related issues
Checklist
Further comments
This PR intentionally maintains the same scope and implementation model as the existing CVE client.
A separate issue,
feat(pyoaev): analysis and impact of api endpoint realignment, will be created to evaluate all API endpoints that are not currently exposed bypyoaev.The goal is to determine whether all endpoints should be made available users via client-python (pyoaev) and to assess the technical and functional impact of any further realignment before implementing any additional changes.