Skip to content

[java][Spring] Add generated annotation for enum converter#23924

Open
jorgerod wants to merge 8 commits into
OpenAPITools:masterfrom
InditexTech:fix/java-spring-enum-converter-generated-annotation
Open

[java][Spring] Add generated annotation for enum converter#23924
jorgerod wants to merge 8 commits into
OpenAPITools:masterfrom
InditexTech:fix/java-spring-enum-converter-generated-annotation

Conversation

@jorgerod
Copy link
Copy Markdown
Contributor

@jorgerod jorgerod commented Jun 2, 2026

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)


Summary by cubic

Adds a @Generated annotation to the Java Spring enum converter (EnumConverterConfiguration) to align with other outputs and reduce false positives in static analysis and coverage. Updates JavaSpring/converter.mustache to import {{javaxPackage}}.annotation.Generated and apply {{>generatedAnnotation}} before @Configuration, and regenerates Spring samples to use the correct jakarta/javax import accordingly.

Written for commit 41eaf91. Summary will update on new commits.

Review in cubic

@jorgerod jorgerod marked this pull request as ready for review June 3, 2026 08:50
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 26 files

Re-trigger cubic

@jorgerod jorgerod changed the title fix: add generated annotation for enum converter [java][Spring] Add generated annotation for enum converter Jun 3, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 29 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 29 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/openapi3/client/petstore/spring-cloud-spring-pageable/src/main/java/org/openapitools/api/PetApi.java">

<violation number="1">
P1: The `spring-cloud-spring-pageable` sample has regressed from Spring `Pageable` integration to explicit query parameters, contradicting the sample's purpose and the PR description.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant