[Spring] fix required constructor missing setter to parent

modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModel.java

@@ -141,6 +141,7 @@ public class CodegenModel implements IJsonSchemaValidationProperties {
     @Getter @Setter
     public List<CodegenProperty> parentVars = new ArrayList<>();
     public List<CodegenProperty> parentRequiredVars = new ArrayList<>();
+    public List<CodegenProperty> requiredVarsOptionalInParent = new ArrayList<>();
     @Getter @Setter
     public List<CodegenProperty> nonNullableVars = new ArrayList<>(); // a list of non-nullable properties
     @Getter @Setter

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java

@@ -788,6 +788,13 @@ public Map<String, ModelsMap> postProcessAllModels(Map<String, ModelsMap> objs)
                 }
                 if (codegenModel.getParentModel() != null) {
                     codegenModel.parentRequiredVars = new ArrayList<>(codegenModel.getParentModel().requiredVars);
+
+                    codegenModel.requiredVarsOptionalInParent = codegenModel.requiredVars.stream()
+                            .filter(cp ->
+                                codegenModel.getParentModel().getVars().stream()
+                                .anyMatch(p-> !p.getRequired() && cp.getName().equals(p.getName()))
+                            )
+                            .collect(Collectors.toList());
                 }
                 // There must be a better way ...
                 for (String imp : inheritedImports) {

modules/openapi-generator/src/main/resources/JavaSpring/pojo.mustache

@@ -115,6 +115,9 @@ public {{>sealed}}class {{classname}}{{#parent}} extends {{{parent}}}{{/parent}}
     {{/openApiNullable}}
     {{/required}}
     {{/vars}}
+    {{#requiredVarsOptionalInParent}}
+    {{name}}({{name}});
+    {{/requiredVarsOptionalInParent}}
   }
   {{/hasRequired}}
   {{/generatedConstructorWithRequiredArgs}}

modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java

@@ -8132,4 +8132,12 @@ void schemaMappingWithNullableAllOfRendersNullableJavaProperty() throws IOExcept
         JavaFileAssert.assertThat(files.get("MyObject.java"))
                 .assertProperty("optionalRef").withType("JsonNullable<com.example.ExternalModel>");
     }
+
+    @Test
+    void issue_23918() throws IOException {
+        final Map<String, File> files = generateFromContract("src/test/resources/3_0/spring/issue_23918.yaml", SPRING_BOOT,
+                Map.of(GENERATE_CONSTRUCTOR_WITH_REQUIRED_ARGS, "true", USE_OPTIONAL, "true"));
+        JavaFileAssert.assertThat(files.get("PartyRoleSpecification.java"))
+                .fileContains("name(name);", "PartyRoleSpecification(String atType, String name)");
+    }
 }

modules/openapi-generator/src/test/resources/3_0/spring/issue_23918.yaml

@@ -0,0 +1,45 @@
+openapi: 3.0.3
+info:
+  title: requiredArg
+  version: 1.0.0
+paths: {}
+components:
+  schemas:
+    Entity:
+      type: object
+      required:
+        - '@type'
+      properties:
+        '@type':
+          type: string
+    EntitySpecification:
+      allOf:
+        - $ref: "#/components/schemas/Entity"
+        - type: object
+          properties:
+            name:
+              type: string
+              description: Name given to the specification
+            lastUpdate:
+              type: string
+              format: date-time
+            lifecycleStatus:
+              type: string
+            isBundle:
+              type: boolean
+            version:
+              type: string
+      discriminator:
+        propertyName: "@type"
+        mapping:
+          EntitySpecification: "#/components/schemas/EntitySpecification"
+          PartyRoleSpecification: "#/components/schemas/PartyRoleSpecification"
+    PartyRoleSpecification:
+      allOf:
+        - $ref: "#/components/schemas/EntitySpecification"
+        - type: object
+          properties:
+            status:
+              type: string
+          required:
+            - name

samples/openapi3/server/petstore/spring-boot-oneof-interface/src/main/java/org/openapitools/model/Bar.java

@@ -46,6 +46,7 @@ public Bar() {
   public Bar(String id, String atType) {
     super(atType);
     this.id = id;
+    id(id);
   }
 
   public Bar id(String id) {

samples/openapi3/server/petstore/spring-boot-oneof-sealed/src/main/java/org/openapitools/model/Bar.java

@@ -46,6 +46,7 @@ public Bar() {
   public Bar(String id, String atType) {
     super(atType);
     this.id = id;
+    id(id);
   }
 
   public Bar id(String id) {

samples/openapi3/server/petstore/spring-boot-oneof/src/main/java/org/openapitools/model/Bar.java

@@ -46,6 +46,7 @@ public Bar() {
   public Bar(String id, String atType) {
     super(atType);
     this.id = id;
+    id(id);
   }
 
   public Bar id(String id) {