Defer media body downloads during refresh#29
Open
tripledoublev wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Follow-up on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refreshed_filesfor API compatibility while deferring body refreshes to explicit media endpoints/mediaendpoints with per-peer and overall request budgetsis_downloadedfrom the local group blob store instead of asking a remote peerVerification
cargo checkcargo test test_refresh_group_with_file -- --nocapturecargo test test_refresh_member_joined_before_owner_uploads -- --nocapturegit diff --checkReview notes
is_downloadedwas still using the remote-repo hash check and route lookup was outside the timeout; both were fixed.!repo.can_write()gate for file-body downloads.all_fileswithout media bodies, keeprefreshed_filesempty, keepis_downloadedfalse until explicit media GET, then flip it true after download.