fix(conformance): preserve protected matrix failure diagnostics - #140
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
One evidence secret-scan path is wrapped with the report diagnostic instead of the new scan diagnostic, which would misattribute failures to the wrong bounded substage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR tightens Phase 1 conformance failure reporting by introducing finer-grained, allowlisted “substage” diagnostics for checkout and schema-v2 evidence finalization, so protected matrix failures surface the correct failing boundary without exposing private output/paths.
Changes:
- Adds new allowlisted diagnostic IDs for per-checkout and per-finalization boundaries (report/operator-state/isolation/assertions/build/serialize/scan/retain).
- Wraps checkout steps and schema-v2 evidence finalization steps in bounded stage helpers so nested failures preserve the most specific diagnostic.
- Updates governed workflow hashes, lock authority metadata, and conformance documentation to match the new governed bytes.
File summaries
| File | Description |
|---|---|
src/phase1-conformance.test.ts |
Adds tests ensuring substage diagnostics survive nested stage wrappers and dual-failure cleanup scenarios. |
src/phase1-conformance-lock.test.ts |
Updates expected harness authority revision/tree/blob/sha256 values for the governed files. |
scripts/phase1-schema-v2-producer.mjs |
Introduces new allowlisted substages and wraps checkout + evidence-finalization boundaries to preserve diagnostics and retain underlying causes. |
scripts/phase1-conformance.mjs |
Extends the public diagnostic allowlist to include the new bounded stage IDs. |
phase1-conformance.lock.json |
Re-pins harness authority metadata for the updated governed artifacts. |
docs/phase1-conformance.md |
Documents the new checkout/evidence-finalization substage diagnostics and updates governed hash listings. |
.github/workflows/client-v1-conformance.yml |
Updates the pinned size/hash entries for governed script bytes. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 7, 2026
BunsDev
added a commit
that referenced
this pull request
Sep 7, 2026
Preserve the committed harness authority ancestry and correct the report secret-scan diagnostic reviewed in #140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protected run 34074618490 passed on macOS but reported only generic checkout failure on Windows and evidence-finalization failure on Linux. Split those boundaries into allowlisted substage diagnostics so the next run identifies the failing operation without retaining private output or paths.
Preserve the primary diagnostic when finalization and artifact cleanup both fail, while retaining both underlying errors. Update governed workflow hashes, harness authority metadata, and diagnostic documentation.
Validation on final head
25b3bc6:corepack pnpm test: normal 551 passed / 61 skipped; heavy 394 passed / 35 skipped.corepack pnpm typecheck,corepack pnpm lint,corepack pnpm build, andgit diff --check: pass (build verified on identical production source before the metadata-only pin commit).This is diagnostic instrumentation, not passing release evidence. After merge, rebind the SDK validator to the reachable Chat producer and rerun the protected three-platform matrix. SDK #38 remains open until Linux and Windows pass; SDK #40, #41, and Chat #86 remain downstream.
Merge with an actual merge commit: the lock references a behavior commit on this branch. Squash/rebase would break its required ancestry.