Edit in sandbox: create or join a sandbox from a live workflow#4901
Open
elias-ba wants to merge 1 commit into
Open
Edit in sandbox: create or join a sandbox from a live workflow#4901elias-ba wants to merge 1 commit into
elias-ba wants to merge 1 commit into
Conversation
From a live workflow, "Edit in sandbox" opens a picker to either branch a new sandbox from the current live version or join an active one, then lands the user in the sandbox editor with that workflow's trigger live and its own endpoint. The parent stays untouched until a change is promoted back (a later slice of the epic). - New channel events: list a parent's active sandboxes (with collaborators and the joinable workflow, sorted by last edited) and create-and-open a sandbox. - Creating clones the parent project, then promotes the edited workflow to live inside the sandbox; the other cloned workflows stay draft so state and triggers remain coherent. The sandbox copy stays editable because the read-only lock only applies to live workflows outside a sandbox. - A sandbox badge in the editor header. Server-side errors (permission, usage limit) surface their real message in the picker rather than a generic one.
Security Review ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #4859. From a live workflow, "Edit in sandbox" opens a picker to either branch a new sandbox from the current live version or join an active one, then lands the user in the sandbox editor with that workflow's trigger live and its own endpoint. The parent project is untouched; changes come back through promotion in a later slice of the epic.
What's included
sandboxbadge shown when editing inside a sandbox.Demo
sandboxbadge.Scope and follow-ups
Reuses the existing
:provision_sandboxpermission (owner/admin/editor) and the:new_sandboxusage limit. There's no last-editor field on a project, so the list sorts by last-edited time and shows collaborators.Two things deliberately left for their own slices rather than half-built here: refining what the header shows inside a sandbox (suppressing the draft/live controls and adding Promote) belongs with the promote work (#4861); and hiding the action client-side for users who can't provision (today the server enforces it and the picker surfaces the reason) needs a permission flag on the session context.
The who-can-edit-in-sandbox permission model and what "join an active sandbox" should mean access-wise are product calls worth a quick confirm with the feature owners before this leaves the epic branch.
Additional notes for the reviewer