fix(asusd): carry Slash display mode as u8 over the D-Bus stack - #273
Open
NB-Group wants to merge 1 commit into
Open
fix(asusd): carry Slash display mode as u8 over the D-Bus stack#273NB-Group wants to merge 1 commit into
NB-Group wants to merge 1 commit into
Conversation
Carry the Slash display mode as a u8 end-to-end instead of leaking the animation interval where callers expect the mode discriminant: rog-slash data type is #[repr(u8)], the asusd trait impl and rog-dbus binding return it as u8, the asusctl CLI reader parses u8, and rog-control-center's setup_slash consumes it with a short retry (the single post-startup read races asusd). Self-contained backend change; no UI page touches.
📝 WalkthroughSummary by CodeRabbit
WalkthroughSlash mode access now uses raw ChangesSlash mode validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #230, where it was buried inside the UI redesign. It is a self-contained backend change and has nothing to do with the UI work, so it gets its own PR.
The Slash display mode was leaking through the D-Bus stack as the raw animation interval, while every caller actually wanted the mode discriminant. Thread it as u8 instead:
SlashModeis now#[repr(u8)]u8u8setup_slashconsumesu8, with a short retry because the single post-startup read races asusd coming upNo UI page is touched. Builds clean across rog-slash / rog-dbus / asusd / asusctl / rog-control-center.