Fix conda activation in SWE-bench prompts: source absolute path#754
Open
VascoSch92 wants to merge 1 commit into
Open
Fix conda activation in SWE-bench prompts: source absolute path#754VascoSch92 wants to merge 1 commit into
VascoSch92 wants to merge 1 commit into
Conversation
The activation line used ./opt/miniconda3/... which is a relative path (resolved against the repo cwd, where it does not exist) and executes the script instead of sourcing it, so it cannot activate testbed in the agent's shell. Use 'source /opt/miniconda3/...' as the swefficiency prompt already does.
Collaborator
|
@VascoSch92 thank you! do you have eval monitor links where this was tested? |
Member
Author
|
@juanmichelini https://openhands-eval-monitor.vercel.app/?run=swebench%2Flitellm_proxy-anthropic-claude-sonnet-4-6%2F28005569773%2F&days=15 Logs are clean: no ModuleNotFoundError, no sklearn import failures, no conda errors anywhere in logs. But perhaps you can double-check just to be sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the conda-activation line in the
swebenchandswebenchmultilingualdefault prompts:Why
./opt/miniconda3/...is a relative path (resolved against the agent's cwd/workspace/<repo>/, where it does not exist) and it executes the script instead ofsource-ing it, so it cannot activatetestbedin the agent's shell.benchmarks/swefficiency/prompts/default.j2already uses the correct. /opt/...form; this aligns the other two.This was harmless while the runtime auto-activated
testbed, but under the v1.24.0 agent-server (agent runs as the non-rootopenhandsuser, so the base image's/root/.bashrcauto-activation never fires) the shell starts in base conda and this broken line is the only activation path. Weak models copy it verbatim and fail; strong models work around it.Minimal, prompt-only change. Closes #753. Related: #698.