Skip to content

Add Hebrew translations for OHM Time Slider#19

Merged
1ec5 merged 1 commit into
OpenHistoricalMap:mainfrom
yarons:patch-1
Sep 30, 2025
Merged

Add Hebrew translations for OHM Time Slider#19
1ec5 merged 1 commit into
OpenHistoricalMap:mainfrom
yarons:patch-1

Conversation

@yarons

@yarons yarons commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Added Hebrew as "he" with the appropriate language code, thanks.

@jeffreyameyer

Copy link
Copy Markdown
Member

@yarons - I'm not in the PR approval chain, but I wanted to send a quick "תודה" for taking the time to submit this.

@jeffreyameyer

Copy link
Copy Markdown
Member

@erictheise @1ec5 - not sure which of you is more appropriate for this PR.

@yarons

yarons commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

Thank you so much @jeffreyameyer!

@1ec5 1ec5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@1ec5 1ec5 merged commit 8d580a3 into OpenHistoricalMap:main Sep 30, 2025
@jeffreyameyer

Copy link
Copy Markdown
Member

@1ec5 - soft eta for this going to production is next week, correct? Or, should it be live sooner than that?

@1ec5

1ec5 commented Sep 30, 2025

Copy link
Copy Markdown
Member

Per OpenHistoricalMap/issues#1057 (comment), this commit hash needs to be updated to point to at least 8d580a3.

We also need to copy-paste this file into https://github.com/OpenHistoricalMap/ohm-website/blob/staging/app/assets/javascripts/leaflet-ohm-timeslider.js, because OpenHistoricalMap/ohm-website#260 created a second copy of the files. Improving how we manage this code has been on the backburner because we intend to replace it entirely: OpenHistoricalMap/issues#914.

@1ec5

1ec5 commented Sep 30, 2025

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants