Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion general/package/mbedtls-openipc/mbedtls-openipc.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ MBEDTLS_OPENIPC_VERSION = 2.25.0
MBEDTLS_OPENIPC_SITE = $(call github,ARMmbed,mbedtls,v$(MBEDTLS_OPENIPC_VERSION))
MBEDTLS_OPENIPC_CONF_OPTS = \
-DENABLE_PROGRAMS=$(if $(BR2_PACKAGE_MBEDTLS_OPENIPC_PROGRAMS),ON,OFF) \
-DENABLE_TESTING=OFF
-DENABLE_TESTING=OFF \
-DCMAKE_POLICY_VERSION_MINIMUM=3.5

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already covered globally, so this line is a no-op in practice.

Makefile:7 on master has:

export CMAKE_POLICY_VERSION_MINIMUM := 3.5

(from 656094d / #1978). CMake honours CMAKE_POLICY_VERSION_MINIMUM as an environment variable as well as a -D cache entry, and Buildroot's pkg-cmake.mk CONFIGURE_CMDS doesn't scrub the environment — so the export already reaches this package's cmake invocation.

Verified with host cmake 4.3.3 against the extracted mbedtls-openipc-2.25.0 tree:

$ cmake -S mbedtls-openipc-2.25.0 -B /tmp/a
CMake Error at CMakeLists.txt:23 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

$ CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake -S mbedtls-openipc-2.25.0 -B /tmp/c
-- Configuring done (0.7s)
-- Generating done (0.2s)
-- Build files have been written to: /tmp/c

The env-var form (which master already sets) is enough on its own.

MBEDTLS_OPENIPC_INSTALL_STAGING = YES
MBEDTLS_OPENIPC_LICENSE = Apache-2.0
MBEDTLS_OPENIPC_LICENSE_FILES = apache-2.0.txt
Expand Down