Skip to content

gk710x: enable WPA crypto in kernel configs - #2258

Open
shipa-2 wants to merge 1 commit into
OpenIPC:masterfrom
shipa-2:pr/gk710x-wpa-crypto
Open

gk710x: enable WPA crypto in kernel configs#2258
shipa-2 wants to merge 1 commit into
OpenIPC:masterfrom
shipa-2:pr/gk710x-wpa-crypto

Conversation

@shipa-2

@shipa-2 shipa-2 commented Aug 11, 2026

Copy link
Copy Markdown

Summary

  • Enable CONFIG_CRYPTO_CCM, CONFIG_CRYPTO_CTR, CONFIG_CRYPTO_SEQIV, and CONFIG_CRYPTO_SHA256 in gk710x / gk710xs generic kernel configs for WPA2.

Test plan

  • Rebuild gk7102_lite / gk7102s_lite kernel; confirm crypto options are set
  • WPA2 association works with an appropriate Wi-Fi driver

Part of splitting #2256.

Made with Cursor

Turn on CCM, CTR, SEQIV and SHA256 needed for WPA2 on GK7102/GK7102S.

Co-authored-by: Cursor <cursoragent@cursor.com>
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

gk710x/gk710xs: enable kernel crypto options required for WPA2

⚙️ Configuration changes ✨ Enhancement 🕐 Less than 10 minutes

Grey Divider

AI Description

• Enable CCM/CTR/SEQIV/SHA256 crypto primitives in GK710x defconfigs for WPA2.
• Apply the same WPA-related crypto settings to both gk710x and gk710xs configs.
Diagram

graph TD
  A["Build system"] --> B["gk710x defconfig"] --> D("Kernel build") --> E["Kernel crypto"] --> F["WPA2 Wi-Fi"]
  A --> C["gk710xs defconfig"] --> D
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Factor crypto settings into a shared config fragment
  • ➕ Avoids duplicating identical WPA crypto options across gk710x and gk710xs configs
  • ➕ Reduces future drift when adding/removing required crypto primitives
  • ➖ May require build-system support for merging fragments (or a small refactor)
  • ➖ Slightly less direct to read compared to a single monolithic defconfig
2. Build crypto options as modules (m) instead of built-in (y)
  • ➕ Potentially reduces base kernel image size if modules can be omitted/loaded on demand
  • ➕ Allows field updates to crypto modules without full kernel replacement (platform permitting)
  • ➖ WPA2 association may fail if modules aren’t available/auto-loaded early enough
  • ➖ Embedded deployments often ship without module loader or with immutable rootfs

Recommendation: The PR’s approach (setting the required crypto options to built-in in both defconfigs) is appropriate for ensuring WPA2 works reliably on minimal embedded images. If these two defconfigs are expected to stay in lockstep, consider a follow-up to centralize the shared WPA crypto options into a common fragment to prevent future divergence.

Files changed (2) +8 / -8

Other (2) +8 / -8
gk710x.generic.configEnable CCM/CTR/SEQIV/SHA256 crypto for WPA2 +4/-4

Enable CCM/CTR/SEQIV/SHA256 crypto for WPA2

• Turns on CONFIG_CRYPTO_CCM, CONFIG_CRYPTO_CTR, CONFIG_CRYPTO_SEQIV, and CONFIG_CRYPTO_SHA256. These kernel crypto primitives are commonly required for WPA2 (CCMP/AES-CCM and related helpers).

br-ext-chip-goke/board/gk710x/gk710x.generic.config

gk710xs.generic.configMatch gk710x WPA2 crypto enables in gk710xs config +4/-4

Match gk710x WPA2 crypto enables in gk710xs config

• Mirrors the same crypto option enables as gk710x: CCM, CTR, SEQIV, and SHA256. Keeps GK7102S generic kernel configuration aligned for WPA2 capability.

br-ext-chip-goke/board/gk710x/gk710xs.generic.config

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@flyrouter flyrouter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major objections if it’s really necessary.
However, as with other Goke cores, it might be worth setting these some options via =m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants