Fix AX HE capability advertisement#1060
Open
DurkaEbanaya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Body
Summary
This PR fixes AX/HE capability advertisement for Intel iwx devices and hardens HE IE handling.
Main changes:
IEEE80211_F_HEONwhen setting up iwx HE rates/capabilities.phy_cap_info[0].ItlNetworkUserClient.Why
On a 160 MHz-capable AX setup, the driver built an HE Capabilities IE but did not advertise the 5 GHz HE channel width bits in
phy_cap_info[0].In testing, that caused reverse/downlink throughput around ~130 Mbit/s, with RX PHY reporting VHT at only 20 MHz. After advertising the correct HE 5 GHz width capabilities and keeping the normal VHT+HE association path, the same setup negotiated stable wide-channel operation.
This PR intentionally does not force HE-only association or remove VHT capabilities. The client advertises its VHT and HE capabilities and leaves the final VHT/HE downlink decision to the AP/firmware.
Testing
Built successfully:
xcodebuild -project itlwm.xcodeproj -scheme itlwm -configuration Debug build LAN iperf3 tests after reboot: iperf3 -c 192.168.1.42 -R -t 60 -O 5: 568 Mbit/s, 6 retransmits iperf3 -c 192.168.1.42 -t 60 -O 5: 471 Mbit/s iperf3 -c 192.168.1.42 -R -P 4 -t 60 -O 5: 647 Mbit/s aggregate iperf3 -c 192.168.1.42 -P 4 -t 60 -O 5: 474 Mbit/s aggregate, 0 retransmits Compared with the pre-fix behavior, reverse/downlink throughput improved from ~130 Mbit/s to stable wide-channel performance, without forcing HE-only operation.