Skip to content

feat: implement content shape modifiers - #1099

Merged
Kyle-Ye merged 6 commits into
bugfix/pathfrom
feature/content_shape
Sep 26, 2026
Merged

Kyle-Ye merged 6 commits into
bugfix/pathfrom
feature/content_shape

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Add both View.contentShape overloads with shape-based hit testing and interaction-kind routing.
  • Complete the focus values and accessibility bit assignment in ContentShapeKinds, and document the public modifier types.

Stack

Depends on #1098.

@Kyle-Ye
Kyle-Ye added this pull request to stack #1100 September 25, 2026 16:44
@github-actions github-actions Bot added area: accessibility Accessibility APIs, settings, semantics, or behavior. area: event-gesture Events, gestures, tracing, or interaction plumbing. area: view View APIs, modifiers, AnyView, ForEach, DynamicView, and related behavior. type: feature New API, behavior, platform support, or user-facing capability. labels Sep 25, 2026
@tuist

tuist Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 5032e604e

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 28.5s 5032e604e

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 175 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.26%. Comparing base (82e07dd) to head (24f60c4).

Files with missing lines Patch % Lines
...tUI/Event/Responder/ContentShapeKindModifier.swift 0.00% 88 Missing ⚠️
...SwiftUI/Event/Responder/ContentShapeModifier.swift 0.00% 67 Missing ⚠️
...wiftUICore/Event/Responder/ContentShapeKinds.swift 0.00% 12 Missing ⚠️
...nSwiftUI/Accessibility/AccessibilityNodeList.swift 0.00% 6 Missing ⚠️
...nSwiftUI/Accessibility/AccessibilityGeometry.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           bugfix/path    #1099      +/-   ##
===============================================
- Coverage        33.37%   33.26%   -0.12%     
===============================================
  Files              803      805       +2     
  Lines            63817    63992     +175     
===============================================
- Hits             21301    21284      -17     
- Misses           42516    42708     +192     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 770047e into main Sep 26, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/content_shape branch September 26, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: accessibility Accessibility APIs, settings, semantics, or behavior. area: event-gesture Events, gestures, tracing, or interaction plumbing. area: view View APIs, modifiers, AnyView, ForEach, DynamicView, and related behavior. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant