Create sanitizer tests - #69
Draft
ajanczew wants to merge 9 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated GitHub Actions workflow to run sanitizer-instrumented builds/tests on a schedule (and manually), and adjusts an AVX-512 unit-test helper to avoid UB that sanitizers would flag.
Changes:
- Added a new scheduled/manual GitHub Actions workflow to run unit tests under ASan/TSan/UBSan/IntSan and app-level tests under MSan.
- Added a UBSan/IntSan suppression list for known libstdc++ false positives.
- Updated
dwt_horizontal_depricated_avx512to widen intermediate arithmetic toint64_tto avoid signed-overflow UB during sanitizer runs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/UnitTests/UnitTest_AVX512/CodeDeprecated-avx512.cc | Avoids signed-overflow UB in scalar tail calculations so UBSan/IntSan runs are actionable. |
| .github/workflows/sanitizer_tests.yaml | Adds the sanitizer CI workflow covering multiple sanitizers and artifacts on failure. |
| .github/config/ubsan_suppressions.txt | Provides suppressions to reduce known standard-library false positives during integer/UB sanitizers. |
Suppressed comments (1)
.github/workflows/sanitizer_tests.yaml:138
- Same as above: the MSan build currently uses
jobs=$(nproc), which may overwhelm memory/CPU on big self-hosted runners. Using a capped job count improves reliability for sanitizer-instrumented builds.
- name: 'Build: debug with memory sanitizer'
working-directory: Build/linux
run: |
./build.sh debug test sanitizer=memory cc=clang cxx=clang++ jobs=$(nproc)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ajanczew
marked this pull request as ready for review
August 11, 2026 15:02
Collaborator
|
Do not run sanitizers against unittests. Use SvtJpegxsEncApp and SvtJpegxsDecApp with different input parameters. |
ajanczew
marked this pull request as draft
August 12, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.