chore: pin typos as a local hook so autoupdate can't unpin it#6075
Merged
Conversation
crate-ci/typos publishes moving tags (v1, typos-dict-*), so autoupdate rewrites any pinned rev back to a mutable reference (PRQL#5481, PRQL#5510). A local hook has no rev; the version pin in additional_dependencies sticks, matching the existing lychee pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
prql-bot
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6074, fixing the last unpinned hook. The
typosrev has been the mutablev1tag, which pre-commit never updates after first install — so every machine and CI environment silently freezes whatever version it first built, and versions drift apart over time.Pinning an exact tag doesn't stick: crate-ci/typos publishes moving tags (
v1,typos-dict-*) on the same repo, andpre-commit autoupdatere-selects among them — #5481 pinnedv1.9.0and #5510 pinnedv1.37.2, and the next weekly autoupdate reverted each back tov1(one week it even landed ontypos-dict-v0.13.13). This converts typos to arepo: localhook with the version pinned viaadditional_dependencies: ["typos==1.48.0"](PyPI binary wheels), the same pattern the config already uses for lychee. Local hooks have norev, so autoupdate has nothing to rewrite. The hook definition mirrors upstream's exactly (entry: typos,args: [--write-changes, --force-exclude],types: [text]) and keeps the existingpass_filenames: falseworkaround for crate-ci/typos#347.Trade-off: typos bumps become manual (autoupdate and dependabot don't track
additional_dependencies), which beats an unpinned version frozen per-machine. typos 1.48.0 runs clean across the repo — no new dictionary findings — andpre-commit run --all-filespasses with the mutable-reference warning gone.