Skip to content

fix(analytics): onboarding median shows "< 1 min" for waits under a minute #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplacht merged 1 commit into from
Oct 1, 2026
Merged

fix(analytics): onboarding median shows "< 1 min" for waits under a minute #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backend/analytics/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,8 @@ def onboarding_funnel(days: int) -> Funnel:

def _duration(delta: timedelta) -> str:
minutes = int(delta.total_seconds() // 60)
if minutes < 1:
return '< 1 min'
if minutes < 60:
return f'{minutes} min'
if minutes < 48 * 60:
Expand Down
9 changes: 9 additions & 0 deletions backend/tests/analytics/test_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ def test_steps_and_median(self, admin_client: Client) -> None:
# median of 10 min and 3 h
assert funnel['median_to_first_plan'] == '1.6 h'

def test_median_under_a_minute(self) -> None:
user = signup('quick')
plan = baker.make(PlanningPlan, user=user)
PlanningPlan.objects.filter(pk=plan.pk).update(created_at=user.date_joined + timedelta(seconds=30))

funnel = dashboard.onboarding_funnel(7)

assert funnel['median_to_first_plan'] == '< 1 min'

def test_no_signups(self) -> None:
User.objects.all().delete()

Expand Down
Loading