fix(user): allow decimal supply cart days - #66
Merged
Merged
Conversation
- supplyCartDays preference is a FloatField (min 0, default 20) instead of an IntegerField, so the supply cart can stock e.g. 2.5 days - stored integer values still read back; no migration (JSON field) - tests: 2.5 round-trips, negative values give 400, stored ints read back Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (172ce74) 4635 4424 95.45% Head commit (29fac9b) 4635 (+0) 4424 (+0) 95.45% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#66) 1 1 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
NPS feedback: the supply cart's stock duration only takes whole days, so you can't stock e.g. 2.5 days to fill a ship's hold. The value is the
supplyCartDaysuser preference, which the backend validated as an integer.Changes
supplyCartDayspreference is aFloatField(min 0, default 20) instead of anIntegerFieldHow it was verified
uv run ruff check,ruff format --check,ty check,uv run pytest(721 passed)/sync-api: schema validates clean;supplyCartDaysis nownumber, which the frontend'sz.number()already acceptssupply_cart_days = 2.5, value survives a reloadDeploy order
Deploy backend first; it is backward compatible. Paired frontend PR: PRUNplanner/frontend#539
🤖 Generated with Claude Code