fix(cache): cut the exchanges cache ttl to 10 minutes - #72
Merged
Merged
Conversation
The FIO exchange webhook invalidates EXCHANGES about every 50 s. With a 1 day ttl every bump left the previous ~110 KB entry behind for 24 h: ~1700 orphaned versions, ~188 MB, pushing Redis to its 192 MB maxmemory and evicting live cache entries under volatile-lru. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (7313dbd) 4883 4673 95.70% Head commit (bb024a7) 4883 (+0) 4673 (+0) 95.70% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#72) 1 1 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since the versioned cache model (f6ac3ec), the FIO exchange webhook calls
CacheManager.invalidate(EXCHANGES)on every price batch, about every 50 s. Invalidation bumps the version and leaves the previous entry in Redis until its TTL ends, andEXCHANGEShad a 1 day TTL.Measured in prod Redis:
gamedata:exchanges:*aloneused_memory_peak193 MB againstmaxmemory192 MB (volatile-lru), so live cache entries were being evictedFix
EXCHANGESTTLDAY→10 * 60. With a bump roughly every minute, that keeps around a dozen stale copies at most (~1.3 MB) and barely lowers the hit rate, since entries rarely lived past the next bump anyway.Planet and storage
:vercounters (no TTL by design) are many keys but negligible memory, left as is.Checks
ruff, ruff format, ty, pytest (809 passed).
🤖 Generated with Claude Code