fix(user): purge used and expired verification codes daily - #73
Merged
Merged
Conversation
- add user_purge_verification_codes task: bulk-deletes codes that are used or older than EXPIRY_TIME (same cutoff as VerificationCode.is_expired) - log verification_codes_purged with the deleted count - test: used and expired codes deleted, active code kept, for both purposes Closes #12 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.01% coverage variation
Metric Results Coverage variation ✅ +0.01% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (b50ca03) 4883 4673 95.70% Head commit (be2606f) 4891 (+8) 4681 (+8) 95.71% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#73) 9 9 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Verification codes were never deleted once used or expired. The only cleanup was replacing a user's previous code of the same purpose, so every user kept a dead row (code stored in plaintext). This adds a daily purge task.
Closes #12
Changes
user_purge_verification_codestask: bulk-deletes codes that are used or older thanEXPIRY_TIME(same cutoff asVerificationCode.is_expired)verification_codes_purgedwith the deleted countHow it was verified
uv run ruff check,uv run ruff format --check,uv run ty check --exclude "**/migrations/*.py",uv run pytest(811 passed).Deploy step
After deploy, add a Periodic task in the admin: task
user_purge_verification_codes, crontab daily (e.g. 03:00 UTC). Periodic tasks live in the DB (DatabaseScheduler); the task does not run until this row exists.Note (out of scope)
EXPIRY_TIMEreads onlyverification_expiry_minutes, so password-reset codes expire on that setting, while the reset email statespassword_reset_expiry_minutes. Both default to 30; it only matters if they diverge.🤖 Generated with Claude Code