fix(gamedata): log fio transport errors at warning in refresh tasks - #76
Merged
Merged
Conversation
- planet and user FIO refresh log httpx.TransportError (timeouts, dropped connections) as a warning without traceback; retry bookkeeping unchanged - tests cover a ReadTimeout in both tasks, incl. the planet retry state - CLAUDE.md logging rule updated to match Closes #75 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (93510e8) 4891 4681 95.71% Head commit (9114fb5) 4895 (+4) 4685 (+4) 95.71% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#76) 4 4 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Found by
/error-review: during an FIO slowdown, 58planet_refresh_failedevents in 24h werehttpx.ReadTimeouts logged at error level with a traceback. The failure is expected and already handled (the planet is retried after 15 minutes, andfio_request_failedlogs the timeout as a warning), so the error level only flooded the error views.Changes
gamedata_refresh_planetandgamedata_refresh_user_fiodata:httpx.TransportError(timeouts, dropped connections,RemoteProtocolError) now goes to alogger.warningbranch next to the existingHTTPStatusErrorone. Event names and fields unchanged;update_refresh_result(error=...)retry bookkeeping unchanged. Anything else still goes tologger.exception.ReadTimeoutcase in both log-level tests; the planet test also asserts the row isretryingwitherror_count == 1and anext_retry_at.CLAUDE.md: the refresh-failure logging rule now mentions transport errors.Timeouts are unchanged.
gamedata_refresh_planet_infrastructureandgamedata_refresh_cxpckeep logging every failure withlogger.exception(they have no warning branch today).How it was verified
uv run ruff check,uv run ruff format --check,uv run ty check --exclude "**/migrations/*.py": passuv run pytest: 813 passed; the two newReadTimeoutcases fail without the fixCloses #75
🤖 Generated with Claude Code