fix(planning): show total construction cost per building row - #540
Merged
Merged
Conversation
Area and revenue in a production building row cover all buildings of the row, construction cost covered only one (NPS feedback). - construction stat shows per-building cost x amount - tooltip with the single-building cost when amount > 1 - engine constructionCost stays per building (COGM, finance) - en_US key plan.components.production_building.table.construction_per_building - component test for the total and the tooltip Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for prunplanner-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage ∅ diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (d121d2d) 3520 3429 97.41% Head commit (6d63bc7) 3520 (+0) 3429 (+0) 97.41% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#540) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
NPS feedback: "Area and revenue are calculated for all buildings, but construction costs are not." In the plan editor's production building row, area (
area_cost * amount) and daily revenue (construction and workforce × amount) already covered every building of the row. Construction cost was the only stat shown for a single building. It now shows the row total too.Changes
PlanProductionBuilding.vue)PTooltippattern as efficiency)constructionCoststays per building, because COGM andfinance.tsrely on itplan.components.production_building.table.construction_per_buildingHow it was verified
pnpm test && pnpm test:components && pnpm tsc && pnpm lint && pnpm knip, all green.Screenshots
Screenshots: not captured (no spec, so no screenshot config for the e2e run).
🤖 Generated with Claude Code