Repository navigation
fix(api): stop reporting an expired refresh token as an error - #568
Merged
Merged
Conversation
- a 401 of POST /user/refresh/ is a normal logout, no longer sent to PostHog error tracking as ApiClientError; only 429 remains - test asserts the refresh 401 is not tracked; docs/data-layer.md updated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for prunplanner-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (cb0ee51) 3715 3628 97.66% Head commit (938be26) 3715 (+0) 3628 (+0) 97.66% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#568) 1 1 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
An expired refresh token makes
POST /user/refresh/return 401, which ends the session as designed (axiosSetup.ts→refreshOrEndSession).apiService.reportErrorstill sent it to PostHog error tracking asApiClientError, so normal logouts showed up as errors (found by/error-review: 7 events / up to 7 users in 24 h, all expired sessions). The backend already logs the refresh 401.Changes
src/lib/apiService.ts:ApiClientErroris now only a 429; the refresh-401 clause and its comment are removed.src/tests/lib/apiService.test.ts: the refresh-401 case now asserts nothing is tracked or reported.docs/data-layer.md: updated the list of reported errors.How it was verified
pnpm test(118 files, 3712 passed, 1 expected fail),pnpm tsc,pnpm lint,pnpm knip: all pass.🤖 Generated with Claude Code