Repository navigation
FLW-1216: Play memory/DEX monitoring checklist and keep-rule PR check - #693
Open
NikhilFegade wants to merge 1 commit into
Open
NikhilFegade wants to merge 1 commit into
NikhilFegade wants to merge 1 commit into
Conversation
- pr-checks: new proguard-keep-rules job; fails a PR that adds a -keep rule without a comment or a wholesale wildcard keep (only lines the PR adds are checked) - .github/scripts/check_proguard_keeps.py: the check - PR template with the Room-migration / keep-rule / bitmap checklist - docs/PLAY_VITALS_MONITORING.md: thresholds, apps, when and how to check vitals Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Jira ticket
FLW-1216
What changed and why
Google Play starts penalising apps that break the memory, bitmap or DEX-optimisation thresholds in February 2027. This adds the guard rails so the FLW-1211…1215 fixes don't regress:
pr-checks.yml: newproguard-keep-rulesjob (runs on PRs, separate from the build so it fails in seconds). It fails a PR that adds a-keeprule without a#comment above it, or a wholesale wildcard keep such as-keep class org.piramalswasthya.sakhi.** { *; }(allowed only with akeep-broad-ok: <reason>comment). Only lines the PR adds are checked; the existing broad rules are FLW-1211's job..github/scripts/check_proguard_keeps.py: the check used by that job..github/pull_request_template.md: Jira / what / how-tested plus a checklist (Room migration, narrow keep rules, bitmap downsampling).docs/PLAY_VITALS_MONITORING.md: thresholds, the four Play apps, when to check (after each release, each release build, January 2027 checkpoint) and how.No app code changes.
How it was tested
python3 .github/scripts/check_proguard_keeps.py origin/release-2.14on this branch → "ProGuard keep rules OK." (exit 0)🤖 Generated with Claude Code