Skip to content

FLW-1216: Play memory/DEX monitoring checklist and keep-rule PR check - #693

Open
NikhilFegade wants to merge 1 commit into
release-2.14from
FLW-1216_play_monitoring_2.14
Open

NikhilFegade wants to merge 1 commit into
release-2.14from
FLW-1216_play_monitoring_2.14

Conversation

@NikhilFegade

Copy link
Copy Markdown
Member

Jira ticket

FLW-1216

What changed and why

Google Play starts penalising apps that break the memory, bitmap or DEX-optimisation thresholds in February 2027. This adds the guard rails so the FLW-1211…1215 fixes don't regress:

  • pr-checks.yml: new proguard-keep-rules job (runs on PRs, separate from the build so it fails in seconds). It fails a PR that adds a -keep rule without a # comment above it, or a wholesale wildcard keep such as -keep class org.piramalswasthya.sakhi.** { *; } (allowed only with a keep-broad-ok: <reason> comment). Only lines the PR adds are checked; the existing broad rules are FLW-1211's job.
  • .github/scripts/check_proguard_keeps.py: the check used by that job.
  • .github/pull_request_template.md: Jira / what / how-tested plus a checklist (Room migration, narrow keep rules, bitmap downsampling).
  • docs/PLAY_VITALS_MONITORING.md: thresholds, the four Play apps, when to check (after each release, each release build, January 2027 checkpoint) and how.

No app code changes.

How it was tested

  • python3 .github/scripts/check_proguard_keeps.py origin/release-2.14 on this branch → "ProGuard keep rules OK." (exit 0)
  • The new CI job itself runs for the first time on this PR.

🤖 Generated with Claude Code

- pr-checks: new proguard-keep-rules job; fails a PR that adds a -keep rule without a
  comment or a wholesale wildcard keep (only lines the PR adds are checked)
- .github/scripts/check_proguard_keeps.py: the check
- PR template with the Room-migration / keep-rule / bitmap checklist
- docs/PLAY_VITALS_MONITORING.md: thresholds, apps, when and how to check vitals

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ae1e560c-2a09-44f5-95b9-5daed66cee85
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant